Merge pull request phpmyadmin#19449 from kamil-tekiela/getErrorCount

Removal of $GLOBALS['errors']
liviuconcioiu · Dec 16, 2024 · 7f5cd05 · 7f5cd05
2 parents 8138fd1 + ea4d8e4
commit 7f5cd05
Show file tree

Hide file tree

Showing 11 changed files with 78 additions and 288 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -2127,12 +2127,6 @@ parameters:
 			count: 16
 			path: src/Controllers/Database/EventsController.php
 
-		-
-			message: '#^Only booleans are allowed in \|\|, int\<0, max\> given on the left side\.$#'
-			identifier: booleanOr.leftNotBoolean
-			count: 1
-			path: src/Controllers/Database/EventsController.php
-
 		-
 			message: '#^Parameter \#1 \$identifier of static method PhpMyAdmin\\Util\:\:backquote\(\) expects string\|Stringable\|null, mixed given\.$#'
 			identifier: argument.type
@@ -2151,12 +2145,6 @@ parameters:
 			count: 1
 			path: src/Controllers/Database/EventsController.php
 
-		-
-			message: '#^Parameter \#1 \$value of function count expects array\|Countable, mixed given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/Controllers/Database/EventsController.php
-
 		-
 			message: '#^Parameter \#2 \$name of method PhpMyAdmin\\Database\\Events\:\:getDetails\(\) expects string, mixed given\.$#'
 			identifier: argument.type
@@ -2304,12 +2292,6 @@ parameters:
 			count: 1
 			path: src/Controllers/Database/RoutinesController.php
 
-		-
-			message: '#^Only booleans are allowed in a negated boolean, mixed given\.$#'
-			identifier: booleanNot.exprNotBoolean
-			count: 1
-			path: src/Controllers/Database/RoutinesController.php
-
 		-
 			message: '#^Parameter \#1 \$identifier of static method PhpMyAdmin\\Util\:\:backquote\(\) expects string\|Stringable\|null, mixed given\.$#'
 			identifier: argument.type
@@ -5745,12 +5727,6 @@ parameters:
 			count: 11
 			path: src/Controllers/Triggers/IndexController.php
 
-		-
-			message: '#^Only booleans are allowed in \|\|, int\<0, max\> given on the left side\.$#'
-			identifier: booleanOr.leftNotBoolean
-			count: 1
-			path: src/Controllers/Triggers/IndexController.php
-
 		-
 			message: '#^Parameter \#1 \$identifier of static method PhpMyAdmin\\Util\:\:backquote\(\) expects string\|Stringable\|null, mixed given\.$#'
 			identifier: argument.type
@@ -5769,12 +5745,6 @@ parameters:
 			count: 1
 			path: src/Controllers/Triggers/IndexController.php
 
-		-
-			message: '#^Parameter \#1 \$value of function count expects array\|Countable, mixed given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/Controllers/Triggers/IndexController.php
-
 		-
 			message: '#^Parameter \#3 \$name of method PhpMyAdmin\\Triggers\\Triggers\:\:getTriggerByName\(\) expects string, mixed given\.$#'
 			identifier: argument.type
@@ -6579,18 +6549,6 @@ parameters:
 			count: 1
 			path: src/Database/Designer/Common.php
 
-		-
-			message: '#^Argument of an invalid type mixed supplied for foreach, only iterables are supported\.$#'
-			identifier: foreach.nonIterable
-			count: 1
-			path: src/Database/Events.php
-
-		-
-			message: '#^Binary operation "\." between ''\<li\>'' and mixed results in an error\.$#'
-			identifier: binaryOp.invalid
-			count: 1
-			path: src/Database/Events.php
-
 		-
 			message: '#^Binary operation "\.\=" between non\-falsy\-string and mixed results in an error\.$#'
 			identifier: assignOp.invalid
@@ -6606,12 +6564,6 @@ parameters:
 			count: 1
 			path: src/Database/Events.php
 
-		-
-			message: '#^Cannot access an offset on mixed\.$#'
-			identifier: offsetAccess.nonOffsetAccessible
-			count: 7
-			path: src/Database/Events.php
-
 		-
 			message: '#^Cannot cast mixed to int\.$#'
 			identifier: cast.int
@@ -6705,7 +6657,7 @@ parameters:
 		-
 			message: '#^Argument of an invalid type mixed supplied for foreach, only iterables are supported\.$#'
 			identifier: foreach.nonIterable
-			count: 3
+			count: 2
 			path: src/Database/Routines.php
 
 		-
@@ -6714,12 +6666,6 @@ parameters:
 			count: 2
 			path: src/Database/Routines.php
 
-		-
-			message: '#^Binary operation "\." between ''\<li\>'' and mixed results in an error\.$#'
-			identifier: binaryOp.invalid
-			count: 1
-			path: src/Database/Routines.php
-
 		-
 			message: '#^Binary operation "\." between non\-falsy\-string and mixed results in an error\.$#'
 			identifier: binaryOp.invalid
@@ -6741,12 +6687,6 @@ parameters:
 			count: 3
 			path: src/Database/Routines.php
 
-		-
-			message: '#^Cannot access an offset on mixed\.$#'
-			identifier: offsetAccess.nonOffsetAccessible
-			count: 9
-			path: src/Database/Routines.php
-
 		-
 			message: '#^Cannot access offset int\<0, max\> on mixed\.$#'
 			identifier: offsetAccess.nonOffsetAccessible
@@ -6804,7 +6744,7 @@ parameters:
 		-
 			message: '#^Construct empty\(\) is not allowed\. Use more strict comparison\.$#'
 			identifier: empty.notAllowed
-			count: 22
+			count: 21
 			path: src/Database/Routines.php
 
 		-
@@ -6909,12 +6849,6 @@ parameters:
 			count: 4
 			path: src/Database/Routines.php
 
-		-
-			message: '#^Parameter \#1 \.\.\.\$arrays of function array_merge expects array, mixed given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/Database/Routines.php
-
 		-
 			message: '#^Parameter \#2 \$array of function implode expects array\|null, list\<string\|null\>\|string given\.$#'
 			identifier: argument.type
@@ -18111,18 +18045,6 @@ parameters:
 			count: 1
 			path: src/Transformations.php
 
-		-
-			message: '#^Argument of an invalid type mixed supplied for foreach, only iterables are supported\.$#'
-			identifier: foreach.nonIterable
-			count: 1
-			path: src/Triggers/Triggers.php
-
-		-
-			message: '#^Binary operation "\." between ''\<li\>'' and mixed results in an error\.$#'
-			identifier: binaryOp.invalid
-			count: 1
-			path: src/Triggers/Triggers.php
-
 		-
 			message: '#^Binary operation "\.\=" between non\-falsy\-string and mixed results in an error\.$#'
 			identifier: assignOp.invalid
@@ -18138,12 +18060,6 @@ parameters:
 			count: 1
 			path: src/Triggers/Triggers.php
 
-		-
-			message: '#^Cannot access an offset on mixed\.$#'
-			identifier: offsetAccess.nonOffsetAccessible
-			count: 7
-			path: src/Triggers/Triggers.php
-
 		-
 			message: '#^Cannot call method getCreateSql\(\) on PhpMyAdmin\\Triggers\\Trigger\|null\.$#'
 			identifier: method.nonObject