Skip to content

Commit

Permalink
Improve code
Browse files Browse the repository at this point in the history
Signed-off-by: Liviu-Mihail Concioiu <[email protected]>
  • Loading branch information
liviuconcioiu committed Jan 18, 2025
1 parent 3f4a373 commit 7604840
Showing 1 changed file with 1 addition and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -893,11 +893,6 @@ protected function getValuesForInnodbTable(
* Get values for CSV table
*
* https://bugs.mysql.com/bug.php?id=53929
*
* @param array $currentTable current table
* @param int $sumSize sum size
*
* @return array
*/
protected function getValuesForCsvTable(

Check failure on line 897 in libraries/classes/Controllers/Database/StructureController.php

View workflow job for this annotation

GitHub Actions / analyse-php (7.2)

Method PhpMyAdmin\Controllers\Database\StructureController::getValuesForCsvTable() has no return type specified.

Check failure on line 897 in libraries/classes/Controllers/Database/StructureController.php

View workflow job for this annotation

GitHub Actions / analyse-php (7.2)

Method PhpMyAdmin\Controllers\Database\StructureController::getValuesForCsvTable() has parameter $currentTable with no value type specified in iterable type array.

Check failure on line 897 in libraries/classes/Controllers/Database/StructureController.php

View workflow job for this annotation

GitHub Actions / analyse-php (7.2)

Method PhpMyAdmin\Controllers\Database\StructureController::getValuesForCsvTable() has parameter $sumSize with no type specified.
array $currentTable,
Expand All @@ -906,7 +901,7 @@ protected function getValuesForCsvTable(
$formattedSize = $unit = '';

if (
(in_array($currentTable['ENGINE'], ['CSV'], true)
($currentTable['ENGINE'] === 'CSV'
&& $currentTable['TABLE_ROWS'] < $GLOBALS['cfg']['MaxExactCount'])

Check failure on line 905 in libraries/classes/Controllers/Database/StructureController.php

View workflow job for this annotation

GitHub Actions / analyse-php (7.2)

Cannot access offset 'MaxExactCount' on mixed.
|| ! isset($currentTable['TABLE_ROWS'])
) {
Expand Down

0 comments on commit 7604840

Please sign in to comment.