Adds detection for Incognito Browser

ref matomo-org#7039
liviuconcioiu · Feb 7, 2024 · 7e2f537 · 7e2f537
1 parent af2bd50
commit 7e2f537
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/Parser/Client/Browser.php b/Parser/Client/Browser.php
@@ -284,6 +284,7 @@ class Browser extends AbstractClientParser
         'IV' => 'Isivioo',
         'I8' => 'IVVI Browser',
         'IW' => 'Iceweasel',
+        'N3' => 'Incognito Browser',
         'IN' => 'Inspect Browser',
         'I9' => 'Insta Browser',
         'IE' => 'Internet Explorer',
@@ -628,6 +629,7 @@ class Browser extends AbstractClientParser
             'O6', 'P7', 'LJ', 'LC', 'O7', 'N2', 'A8', 'P8', 'RB',
             '1W', 'EV', 'I9', 'V4', 'H4', '1T', 'M5', '0S', '0C',
             'ZR', 'D6', 'F6', 'RC', 'WD', 'P3', 'FT', 'A9', 'X2',
+            'N3',
         ],
         'Firefox'            => [
             'AX', 'BI', 'BF', 'BH', 'BN', 'C0', 'CU', 'EI', 'F1',
@@ -668,7 +670,7 @@ class Browser extends AbstractClientParser
         'B9', 'T0', 'I8', 'O6', 'P7', 'O8', '4B', 'A8', 'P8',
         '1W', 'EV', 'Z0', 'I9', 'V4', 'H4', 'M5', '0S', '0C',
         'ZR', 'D6', 'F6', 'P3', 'FT', 'A9', 'X2', 'NI', 'FG',
-        'TH',
+        'TH', 'N3',
     ];
 
     /**

diff --git a/Tests/Parser/Client/fixtures/browser.yml b/Tests/Parser/Client/fixtures/browser.yml
@@ -8081,3 +8081,14 @@
     family: Android Browser
   headers:
     http-x-requested-with: threads.thor
+-
+  user_agent: Mozilla/5.0 (Linux; Android 10) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.5735.130 Mobile Safari/537.36
+  client:
+    type: browser
+    name: Incognito Browser
+    version: ""
+    engine: Blink
+    engine_version: 114.0.5735.130
+    family: Chrome
+  headers:
+    http-x-requested-with: com.androidbull.incognito.browser
diff --git a/regexes/client/hints/browsers.yml b/regexes/client/hints/browsers.yml
@@ -236,3 +236,4 @@
 'com.securex.browser': 'SecureX'
 'com.sec.android.app.sbrowser.beta': 'Samsung Browser'
 'threads.thor': 'Thor'
+'com.androidbull.incognito.browser': 'Incognito Browser'