Adds detection for Savannah Browser

ref matomo-org#7039
liviuconcioiu · Mar 21, 2022 · 15b8a74 · 15b8a74
1 parent 950153b
commit 15b8a74
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/Parser/Client/Browser.php b/Parser/Client/Browser.php
@@ -359,6 +359,7 @@ class Browser extends AbstractClientParser
         'PV' => 'Safari Technology Preview',
         'S5' => 'Safe Exam Browser',
         'SW' => 'SalamWeb',
+        'VN' => 'Savannah Browser',
         'SD' => 'SavySoda',
         'S9' => 'Secure Browser',
         'SV' => 'SFive',
@@ -465,7 +466,7 @@ class Browser extends AbstractClientParser
             'VG', 'VI', 'VM', 'WP', 'WH', 'XV', 'YJ', 'YN', 'FH',
             'B1', 'BO', 'HB', 'PC', 'LA', 'LT', 'PD', 'HR', 'HU',
             'HP', 'IO', 'TP', 'CJ', 'HQ', 'HI', 'NA', 'BW', 'YO',
-            'DC', 'G8', 'DT', 'AP', 'AK', 'UI', 'SD',
+            'DC', 'G8', 'DT', 'AP', 'AK', 'UI', 'SD', 'VN',
         ],
         'Firefox'            => [
             'AX', 'BI', 'BF', 'BH', 'BN', 'C0', 'CU', 'EI', 'F1',
@@ -497,7 +498,7 @@ class Browser extends AbstractClientParser
         'PE', 'QU', 'RE', 'S0', 'S7', 'SA', 'SB', 'SG', 'SK',
         'ST', 'SU', 'T1', 'UH', 'UM', 'UT', 'VE', 'VV', 'WI',
         'WP', 'YN', 'IO', 'IS', 'HQ', 'RW', 'HI', 'NA', 'BW',
-        'YO', 'PK', 'MR', 'AP', 'AK', 'UI', 'SD',
+        'YO', 'PK', 'MR', 'AP', 'AK', 'UI', 'SD', 'VN',
     ];
 
     /**

diff --git a/Tests/Parser/Client/fixtures/browser.yml b/Tests/Parser/Client/fixtures/browser.yml
@@ -5158,3 +5158,14 @@
     family: Chrome
   headers:
     X-Requested-With: SavySoda.PrivateBrowsing
+-
+  user_agent: Mozilla/5.0 (Linux; Android 8.1.0; moto e5 play Build/OPGS28.54-53-8-20; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/98.0.4758.87 Mobile Safari/537.36
+  client:
+    type: browser
+    name: Savannah Browser
+    version: ""
+    engine: Blink
+    engine_version: ""
+    family: Chrome
+  headers:
+    X-Requested-With: savannah.internet.web.browser
diff --git a/regexes/client/hints/browsers.yml b/regexes/client/hints/browsers.yml
@@ -51,3 +51,4 @@
 'com.browser.tssomas': 'Super Fast Browser'
 'yuce.browser.mini': 'Ui Browser Mini'
 'SavySoda.PrivateBrowsing': 'SavySoda'
+'savannah.internet.web.browser': 'Savannah Browser'