Skip to content

chore(patterns): revert @livetemplate/client back to @latest#97

Merged
adnaan merged 1 commit intomainfrom
chore/revert-client-latest
May 6, 2026
Merged

chore(patterns): revert @livetemplate/client back to @latest#97
adnaan merged 1 commit intomainfrom
chore/revert-client-latest

Conversation

@adnaan
Copy link
Copy Markdown
Contributor

@adnaan adnaan commented May 6, 2026

Both 0.8.41 and 0.8.42 ship the cross-app SPA-nav fix (livetemplate/client#119) and are well-baked in production. Returning to @latest so the patterns app continues to pick up future client patches automatically — the explicit pins were a temporary workaround to bypass jsdelivr's @latest edge cache while we verified the fix end-to-end.

The 0.8.41/0.8.42 explicit pins were temporary — to bypass jsdelivr's
@latest edge cache while we shipped and verified the cross-app SPA-nav
fix (livetemplate/client#119, fix/cross-app-nav-fallback). Both fixes
are now well-baked in production. Returning to @latest so the patterns
app continues to pick up future client patches automatically.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 6, 2026 22:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Patterns app’s production template asset URLs to stop pinning @livetemplate/client to a fixed version and instead use jsDelivr’s @latest, so the example automatically picks up future client fixes without additional repo changes.

Changes:

  • Replaced pinned @livetemplate/client@0.8.42 CDN URLs with @livetemplate/client@latest for both livetemplate.css and the browser client bundle in the non-dev template path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@claude
Copy link
Copy Markdown

claude Bot commented May 6, 2026

Code Review

Overview

This PR reverts a temporary version pin (@0.8.42@latest) in patterns/templates/layout.tmpl. The pin was a short-term workaround while waiting for jsdelivr's @latest edge cache to propagate the SPA-nav fix from livetemplate/client#119. Now that the fix is verified in production across two releases, reverting to @latest is the right call.

Code Quality & Conventions

  • Correct: The CLAUDE.md HTML boilerplate specifies @latest for CDN references. This change restores compliance with that convention.
  • Consistent: Every other template in the repo (todos, chat, live-preview, avatar-upload, etc.) already uses @latest. This brings patterns/templates/layout.tmpl fully in line with the rest of the codebase.

Potential Issues

  • @latest instability risk: Using @latest means any future breaking client change will be picked up automatically with no gating. For an examples/demo repo this is an acceptable trade-off (and matches stated project convention), but worth keeping in mind if a future client release is known to be risky — the temporary pin pattern used here is a solid mitigation when needed.
  • No other concerns. The change is minimal, well-scoped, and the PR description clearly explains the reasoning.

Verdict

Looks good to me. The two lines changed are correct, the motivation is sound, and the approach is consistent with project conventions. ✓

@adnaan adnaan merged commit e398356 into main May 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants