Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treasury: Delta Governor v1 #615

Merged
merged 32 commits into from
Aug 25, 2023
Merged

treasury: Delta Governor v1 #615

merged 32 commits into from
Aug 25, 2023

Commits on Jul 7, 2023

  1. package.json: Update @OpenZeppelin libraries

    Will be required for new checkpoints code and later governor
    implementation.
    victorges committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    cc315d1 View commit details
    Browse the repository at this point in the history
  2. bonding: Create SortedArrays library

    Used for checkpointing logic in bonding state checkpoints
    victorges committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    d42e92c View commit details
    Browse the repository at this point in the history
  3. bonding: Create BondingCheckpoints contract

    Handles historic checkpointing ("snapshotting") and lookup
    of the bonding state.
    victorges committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2abf207 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a9dde9d View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. test/bonding: Test BondingManager and Checkpoints

     - unit tests
     - integration tests
     - gas-report
     - fork test for upgrade
    victorges committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    078f348 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Configuration menu
    Copy the full SHA
    22ee2db View commit details
    Browse the repository at this point in the history
  2. bonding: Allow querying unbonded+uncheckpointed accounts

    This will provide a cleaner experience using governance
    tools, since users that don't have any stake won't get
    errors when querying their voting power. For users that
    do have stake, we will make sure to checkpoint them on
    first deploy.
    victorges committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    2e4157b View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Configuration menu
    Copy the full SHA
    06b7100 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0aa6cd0 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Configuration menu
    Copy the full SHA
    9f007ba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2fd7abb View commit details
    Browse the repository at this point in the history
  3. test/treasury: A couple additional Governor tests

    100% coverage 😎
    victorges committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    34cb455 View commit details
    Browse the repository at this point in the history
  4. test/treasury: Rename Counting unit test mock

    "Harness" seems to make more sense, I could only think
    of that now.
    victorges committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    e970472 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Apply suggestions from code review

    Co-authored-by: Chase Adams <[email protected]>
    victorges and 0xcadams authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a6db562 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Configuration menu
    Copy the full SHA
    0ad3a8f View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Configuration menu
    Copy the full SHA
    bb9ff45 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Configuration menu
    Copy the full SHA
    0c41f78 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d518cd6 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. bonding: Read votes from the end of the round

    Meaning the start of next round instead of the
    current round. This is more compatible with the
    way OZ expects the timepoints to work in the clock
    and snapshots on the Governor framework.
    victorges committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    ccc3ddf View commit details
    Browse the repository at this point in the history
  2. bonding: Make checkpoint reading revert-free

    This changes the BondingVotes implementation to
    stop having so many reverts on supposedly invalid states.
    
    Instead, redefine the voting power (and checkpointed stake)
    as being zero before the first round to be checkpointed.
    
    This had other implications in the code like removing
    changes in BondingManager to make the state complete
    (always having an earnings pool on lastClaimRound).
    Instead, the BondingVotes implementaiton is resilient
    to that as well and just assumes reward() had never
    been called.
    
    This also fixed the redundant reverts between BondingVotes
    and SortedArrays, as now there are almost no reverts.
    victorges committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d5062fe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    292f954 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4f12ce9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e9d3339 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f0fb8ee View commit details
    Browse the repository at this point in the history
  7. bonding: Move constructor to after modifiers

    Just for consistency with other contracts.
    Some docs as a bonus
    victorges committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    9dbb0ae View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Configuration menu
    Copy the full SHA
    b59a538 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. bonding: Implement ERC20 metadata on votes

    This is to increase compatibility with some tools
    out there like Tally, which require only these
    functions from the ERC20 spec, not the full implementation.
    
    So we can have these from the get-go to make things
    easier if we want to make something with them.
    victorges committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    1692ec1 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Configuration menu
    Copy the full SHA
    fecf5a2 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    4246474 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    63d1d19 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8c57a4d View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Configuration menu
    Copy the full SHA
    ddaf2bd View commit details
    Browse the repository at this point in the history