-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate numeral to numbro #237
Conversation
@rickstaa is attempting to deploy a commit to the Livepeer Team on Vercel. A member of the Team first needs to authorize it. |
ad5c1e7
to
bf31821
Compare
I conducted a swift review to ensure the proper display of all Explorer formats, addressing changes resulting from recent library updates. I corrected the discrepancies I identified but encountered two outstanding tasks:
I would appreciate any insights or guidance you can give me on testing procedures 🙂. |
97cd507
to
34f579b
Compare
This commit deprecates the use of the unmaintained [numeral-js](https://github.com/adamwdraper/Numeral-js) library and replaces it with the [numbro](https://github.com/BenjaminVanRyseghem/numbro). This was done to fix livepeer#236 and ensure the explorer is future-proof.
34f579b
to
039d3a2
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build is failing - this may fix it
Thanks for this! Some changes we can hopefully make here |
Co-authored-by: Chase Adams <[email protected]>
Hey @rickstaa it looks like this broke the explorer, I had to revert |
Hi @0xcadams, No problem at all. As mentioned in this comment, I apologize for not thoroughly testing all parts of the explorer before submitting it. In hindsight, I should have kept it as a draft. I understand the inconvenience it caused 😅. I'd happily create a new pull request to test all changes thoroughly. However, I could use some guidance on the best testing practices for all my changes. Specifically, there are two areas of the explorer that I couldn't test:
Your guidance on how to effectively test these changes would be greatly appreciated. |
This pull request deprecates the use of the unmaintained numeral-js library and replaces it with the numbro. This was done to fix #236 and ensure the explorer is future-proof.