fix(signer): handle go-livepeer v0.8.12 fail-closed no-auth check - #56
Draft
rickstaa wants to merge 1 commit into
Draft
fix(signer): handle go-livepeer v0.8.12 fail-closed no-auth check#56rickstaa wants to merge 1 commit into
rickstaa wants to merge 1 commit into
Conversation
rickstaa
force-pushed
the
docs/remote-signer-allow-no-auth
branch
from
July 1, 2026 12:05
95a9024 to
b496fbb
Compare
go-livepeer v0.8.12 (livepeer/go-livepeer#3959) makes a remote signer with a public -httpAddr and no -remoteSignerWebhookUrl fail-closed at startup unless -remoteSignerAllowNoAuth is set. The entrypoint always binds -httpAddr=0.0.0.0, so the signer-only alive-check path (empty REMOTE_SIGNER_WEBHOOK_URL) would refuse to start. Add the opt-in flag on that path — safe because Compose publishes the signing port on 127.0.0.1 only. Bump base image to v0.8.12 and document the behavior in the README. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rickstaa
force-pushed
the
docs/remote-signer-allow-no-auth
branch
from
July 1, 2026 12:07
b496fbb to
66d3a78
Compare
rickstaa
marked this pull request as draft
July 1, 2026 12:07
There was a problem hiding this comment.
Pull request overview
Updates the remote-signer container to accommodate go-livepeer v0.8.12’s new “fail-closed” behavior when running a public -httpAddr without a webhook, so local signer-only “alive checks” can still run.
Changes:
- Add
-remoteSignerAllowNoAuthon the no-webhook execution path inremote-signer/entrypoint.sh. - Bump the remote-signer base image from
livepeer/go-livepeer:v0.8.11tov0.8.12. - Document the new go-livepeer behavior and the stack’s loopback-only port publishing in
README.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| remote-signer/entrypoint.sh | Adds the no-auth allow flag for the no-webhook path to keep the signer startable on go-livepeer v0.8.12. |
| remote-signer/Dockerfile | Updates the base image tag to go-livepeer v0.8.12. |
| README.md | Documents the v0.8.12 behavior and the loopback-only publishing rationale. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
46
to
50
| else | ||
| echo "entrypoint: WARNING: starting remote signer without identity webhook authorization" >&2 | ||
| # Allow running the signer without a webhook (local alive checks only, not production). | ||
| set -- "$@" -remoteSignerAllowNoAuth | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
livepeer/go-livepeer:v0.8.12is not yet published on Docker Hub, so this image won't build until the release is cut. Opening now so the required entrypoint change isn't forgotten. @john please ping when v0.8.12 ships.What
go-livepeer v0.8.12 (livepeer/go-livepeer#3959) makes the remote signer fail closed: a signer bound to a public
-httpAddrwith no-remoteSignerWebhookUrlnow refuses to start unless-remoteSignerAllowNoAuthis explicitly set.Our
remote-signer/entrypoint.shalways binds-httpAddr=0.0.0.0:${SIGNER_PORT}. So:REMOTE_SIGNER_WEBHOOK_URLset): unaffected — the webhook flag is present.REMOTE_SIGNER_WEBHOOK_URL, README §1): would refuse to start on v0.8.12, because go-livepeer keys the check on the internal0.0.0.0bind, not on Compose's loopback-only port publish.Changes
entrypoint.sh: add-remoteSignerAllowNoAuthon the no-webhook path. Safe because Compose publishes the signing port on127.0.0.1only.Dockerfile: bump base imagev0.8.11→v0.8.12.README.md: document the behavior.