runner/live: Cleanup dockerfiles #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several simplifications made. - Removed duplciate python install - Removed NVIDIA packages that already come in base image (or actually should be host only) - Removed intermediate multimedia image and kept only base - Moved python installation to the streamdiffusion image (each pipeline has their own) - Made the live-apps image a little more configurable, it will be reused on top of different pipelines - Probably more stuff
Also templatize it by pipeline and port to make it easy to run other pipes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several simplifications made.
Actual image size didn't reduce much, from 27.4GB to 27.1GB (yeah streamdiffusion is huge and maybe it's downloading models), but I think it will be much easier to work with these now. Also removed all the redundant installations I could find.