Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix dev container build #261

Merged
merged 2 commits into from
Nov 6, 2024
Merged

chore: fix dev container build #261

merged 2 commits into from
Nov 6, 2024

Conversation

rickstaa
Copy link
Collaborator

@rickstaa rickstaa commented Nov 6, 2024

This pull request ensures that the dev container can be successfully built when a pipeline Dockerfile is set. It also cleans up the COPY commands to use the WORKDIR instead of absolute paths for better readability and maintainability.

@rickstaa rickstaa requested a review from leszko November 6, 2024 11:55
This commit ensures that the dev container can be successfully built when a
pipeline Dockerfile is set. It also cleans up the COPY commands to use the
WORKDIR instead of absolute paths for better readability and maintainability.
@rickstaa rickstaa force-pushed the fix_dev_container branch 2 times, most recently from cd78c45 to 7b9e668 Compare November 6, 2024 14:01
This commit reverts the relative docker paths since they can cause
confusion.
@rickstaa rickstaa merged commit cbc6caf into main Nov 6, 2024
1 of 4 checks passed
@rickstaa rickstaa deleted the fix_dev_container branch November 6, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants