-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable new models in audio-to-text #163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
approved these changes
Aug 17, 2024
@rickstaa I made several changes since you last reviewed this PR, so I held off on merging. Could you or @ad-astra-video re-review the latest changes? |
eliteprox
force-pushed
the
whisper-fp16
branch
4 times, most recently
from
October 31, 2024 17:47
b553c6b
to
5e1c90a
Compare
5 tasks
This commit applies some small code improvements to the A2T pipeline.
rickstaa
force-pushed
the
whisper-fp16
branch
from
November 5, 2024 18:57
dae1e50
to
4775d57
Compare
This commit fixes some rebase conflicts that were introduced in the last rebase.
This commit updates to A2T pipeline log so that it is clear the default batch_size and chunk_length_s is used.
This commit removes the debug patch that was accidentally added.
rickstaa
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eliteprox great work! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for new whisper models
distil-whisper/distil-large-v3
andopenai/whisper-medium
.It also optimizes those models to use the appropriate BFLOAT, FLOAT16 or FLOAT32 values.
Credit to @ad-astra-video for intially exploring these models and optimizations