Skip to content

TEL-889: Nullity check for address in connection info - #77

Merged
genseric-ghiro merged 2 commits into
mainfrom
genseric/logic-for-picking-address-when-not-present-in-media
Aug 12, 2026
Merged

TEL-889: Nullity check for address in connection info#77
genseric-ghiro merged 2 commits into
mainfrom
genseric/logic-for-picking-address-when-not-present-in-media

Conversation

@genseric-ghiro

@genseric-ghiro genseric-ghiro commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • In SDP negotiation, a c= line without an address parses to a non-nil ConnectionInformation with a nil Address, so we need to check that the address is non-nil before doing ci.Address.Address; otherwise, this panics and crashes the process along with all the other calls.
  • Also, try choosing the session-level address before directly going to the origin address.

Test

  • Unit tests added

@genseric-ghiro
genseric-ghiro merged commit 5a5218b into main Aug 12, 2026
5 checks passed
@genseric-ghiro
genseric-ghiro deleted the genseric/logic-for-picking-address-when-not-present-in-media branch August 12, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants