TEL-886: Minor touchups for sip rework - #76
Merged
Conversation
alexlivekit
changed the title
alexfish8
approved these changes
Aug 11, 2026
alexfish8
left a comment
alexfish8
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Mostly nits around commenting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
CodeToChar()to avoid hacks around existing eventToChar map.SwitchWriterinto two classes:WriteCloserSwitch[T]Unset initial sample rate, and a generic switch forWriteCloser[T], also has the "unset" sample rate feature.SwitchWriteris now a wrapper aroundWriteCloserSwitch[T], that keepsEnable/Disableand on-demand resampling.PeerDirectionin media config.