fix(sip): implicitly paginate sip trunk queries to skirt twirp limits #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rektdeckard
force-pushed
the
tobias/cus-276-livekit-cli-add-support-for-pagination-to-lk-sip
branch
from
725d85e to
c1c431b
Compare
|
|
||
| type paginatedType[T any] interface { | ||
| protoType[T] | ||
| GetPage() *livekit.Pagination |
There was a problem hiding this comment.
We plan to use this for phone numbers
https://github.com/livekit/protocol/blob/main/protobufs/livekit_models.proto#L31
Should we account for this as well ?
There was a problem hiding this comment.
Sure, I'll take a look
| } | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Do we need to worry about local memory if the api returns a large amount say thousands of phone numbers ?
There was a problem hiding this comment.
I don't know any modern machine that couldn't handle a few MB or even tens of MB or allocation, and this is a short-lived object. I would suggest we impose limit if and only if we get issues? This worked fine with 22K trunks in testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/livekit/issue/CUS-276/livekit-cli-add-support-for-pagination-to-lk-sip-outboundinbound-list
Creates an
ExhaustivePaginatedListhelper function for chunking large data sets using repeated paginatedList*SDK requests to skirt Twirp's 4MB payload limit. Implements it forsip inbound listandsip outbound list.We should also apply this to other potentially large data sets for
room,dispatch,ingressandegresslist operations.Worth noting: the SIP SDK does not seem to respect the
Limityet, but this change should be transparent and will resolve when SDKs are updated.