Expose complete reconnect mode cycle #694
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
@pblazej did an amazing job in #642 with exposing reconnect mode.
But it happens to give info when SDK goes into
.quick
or.full
reconnect but not back to normal connect state.So with current logic there is no way to get info when SDK establishes connection back and it is time to hide reconnect UI elements.
Solution
Expose full cycle for
ReconnectMode
. Since SDK uses Swift optional enumReconnectMode?
there is no way to notify ObjC delegate with changes. Idea is to present.none
ReconnectMode option and use it instead of optional. With such approach it is feasible to notify ObjC delegates. With such logic SDK can tell clients that reconnection process is over. Still not sure wether.none
is the best name for such option so may be reviewers could suggest any better.