Skip to content

chore: refine pii review instructions - #7267

Merged
chenghao-mou merged 1 commit into
mainfrom
chenghao/chore/AGT-3507-refine-pii-review-instructions
Sep 15, 2026
Merged

chenghao-mou merged 1 commit into
mainfrom
chenghao/chore/AGT-3507-refine-pii-review-instructions

Conversation

@chenghao-mou

Copy link
Copy Markdown
Member

Devin flags ordinary diagnostics and hypothetical exception leaks. Require a concrete sensitive value and reachable, unprotected output while retaining content-redaction requirements.

Adopts @GregHolmes's exception-path diagnosis (#7206) and @davidzhao's metadata distinction (#7128); excludes unused-key findings withdrawn in #7104.

Addresses AGT-3507.

Validation: git diff --check and lint passed. make check stopped on existing formatting in recorder_io.py.

Initial prompt and agent context

Model: GPT-6

The current REVIEW.md misfires on many non sensitive log and errors since the introduction. Take a look at Devin's comments on recently merged PRs and see if there is a pattern we can prevent with a better instruction.

Require concrete sensitive output before flagging diagnostic logs or exception paths.

Addresses AGT-3507

Co-authored-by: Greg Holmes <2411269+GregHolmes@users.noreply.github.com>
Co-authored-by: David Zhao <320582+davidzhao@users.noreply.github.com>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@chenghao-mou
chenghao-mou merged commit e611786 into main Sep 15, 2026
10 checks passed
@chenghao-mou
chenghao-mou deleted the chenghao/chore/AGT-3507-refine-pii-review-instructions branch September 15, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants