fix(voice): finish background audio cleanup when the room disconnects - #7228
Open
kiwijuicer wants to merge 1 commit into
Open
fix(voice): finish background audio cleanup when the room disconnects#7228kiwijuicer wants to merge 1 commit into
kiwijuicer wants to merge 1 commit into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BackgroundAudioPlayer.aclose()can wait indefinitely forunpublish_track()when the room has already disconnected or disconnects before the acknowledgement arrives. This can hold up agent shutdown after a call ends.Race unpublishing against the room's
disconnectedevent, skip the request when already disconnected, and remove the listener and settle the owned task on every exit. Connected rooms still wait for the acknowledgement; existing exception suppression and caller cancellation behavior are preserved.Regression coverage exercises normal acknowledgement, both disconnect orderings, cancellation, and an unpublish error. The two disconnect cases fail on unmodified upstream and all five pass with this fix.
make checkpasses.