Skip to content

chore(gradium): remove unused TTS websocket helpers _connect_ws and _close_ws - #7220

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-gradium-remove-unused-tts-websocket-helpers-1b1184
Open

chore(gradium): remove unused TTS websocket helpers _connect_ws and _close_ws#7220
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-gradium-remove-unused-tts-websocket-helpers-1b1184

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Removed TTS._connect_ws and TTS._close_ws from the Gradium TTS plugin. Both private methods had no callers anywhere — neither within the gradium plugin nor in tests, examples, or downstream consumers — and were dead since the file was first introduced. The actual WebSocket connect/close logic is handled inline via async with ... ws_connect(...) (which auto-closes) in ChunkedStream._run and SynthesizeStream._run_ws, using a different header set and timeout mechanism than these stale helpers. Leaving them in place was actively misleading, since they suggested a manual connect/close pattern that does not match the real code path.

History


Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from a team as a code owner September 11, 2026 08:13

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant