Skip to content

fix(sarvam): default TTS retries to zero while honoring explicit conn options - #7218

Open
dhruvladia-sarvam wants to merge 1 commit into
livekit:mainfrom
dhruvladia-sarvam:update/sarvam-tts-disable-retry-plugin
Open

fix(sarvam): default TTS retries to zero while honoring explicit conn options#7218
dhruvladia-sarvam wants to merge 1 commit into
livekit:mainfrom
dhruvladia-sarvam:update/sarvam-tts-disable-retry-plugin

Conversation

@dhruvladia-sarvam

Copy link
Copy Markdown
Contributor

Summary

  • Sarvam TTS no longer inherits LiveKit's default max_retry=3 when AgentSession passes DEFAULT_API_CONNECT_OPTIONS.
  • Failed synthesize() / stream() calls now fail immediately by default instead of replaying the request.
  • Callers can still opt into retries (or change timeout/interval) by passing a constructed APIConnectOptions.

Test plan

  • Start an agent with Sarvam TTS and no custom tts_conn_options; confirm a failed TTS request is not retried.
  • Pass SessionConnectOptions(tts_conn_options=APIConnectOptions(max_retry=N, ...)) and confirm N retries are used.
  • Confirm timeout and retry_interval from an explicit APIConnectOptions are preserved.

@dhruvladia-sarvam
dhruvladia-sarvam requested a review from a team as a code owner September 11, 2026 05:19

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant