fix(voice): preserve transcript flush during session close - #6843
Draft
IanCollection wants to merge 3 commits into
Draft
fix(voice): preserve transcript flush during session close#6843IanCollection wants to merge 3 commits into
IanCollection wants to merge 3 commits into
Conversation
|
ian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AgentSessionclose from ordinary commit/EOU tasksWhy
Normal session close starts
_commit_user_turn(...)withsession_close_transcript_timeoutand immediately closes the activity.AudioRecognition._aclose()then cancelled the same commit task (and its EOU task), so an interim/final transcript still being flushed could never reach conversation history.Only the exact tasks owned by normal session close are preserved. Public commits, handoff teardown, and error-close tasks retain the existing cancellation behavior. If outer cancellation arrives, cleanup is reaped before
CancelledErroris propagated.Impact
The last user utterance can finish committing during normal session shutdown, so
session_close_transcript_timeoutagain provides its intended transcript-capture behavior without broadening waits on unrelated close paths.Validation
AgentSessionclose emitted no final transcript/history item for a pending interim transcriptpytest tests/test_audio_recognition_aclose.py tests/test_agent_session.py --unit -q— 92 passedlivekit.agents) — 206 files passed