fix(voice): complete AgentTask teardown after handoff failures - #6842
Draft
IanCollection wants to merge 1 commit into
Draft
fix(voice): complete AgentTask teardown after handoff failures#6842IanCollection wants to merge 1 commit into
IanCollection wants to merge 1 commit into
Conversation
|
ian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AgentTasksignals inactivity across setup, wait, and handoff teardown failuresAgentActivity.aclose()retryable when teardown raises partway throughWhy
AgentSessionwaits for an activeAgentTaskto become inactive before it can continue closing. The event was set only after asynchronous handoff cleanup. If activity close or parent resume raised (including cancellation during setup), the signal was skipped and session shutdown could wait forever. A failed activity close also marked the activity closed before cleanup completed, preventing a later retry.The inactive signal now covers the full handoff lifecycle, while teardown errors still propagate. A partially failed activity close rolls back its completed flag under the close lock so session shutdown can retry it.
Impact
Session shutdown no longer deadlocks after an
AgentTaskhandoff failure, and partially closed child activities can finish releasing their resources.Validation
AgentSession.aclose()timed out after an injected task-activity close failurepytest tests/test_agent_task_close_race.py tests/test_nested_agent_task.py --unit -q— 5 passed