fix(telemetry): log a warning when the audio recording can't be read at upload time - #6833
Open
dubbl-a wants to merge 1 commit into
Open
fix(telemetry): log a warning when the audio recording can't be read at upload time#6833dubbl-a wants to merge 1 commit into
dubbl-a wants to merge 1 commit into
Conversation
…at upload time A failed read of the local audio recording during session-report upload was swallowed bare, so the upload succeeded with the audio multipart part silently missing and nothing in the logs. Keep the graceful degradation but log the path and the exception, matching the retry warning below. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
longcw
approved these changes
Aug 13, 2026
| "failed to read audio recording for session report upload, " | ||
| "uploading without the audio part (path=%s): %s", | ||
| report.audio_recording_path, | ||
| e, |
Contributor
There was a problem hiding this comment.
can you use exc_info=e instead of %s?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6832.
A failed read of the local audio recording during session-report upload is currently swallowed bare, so the upload succeeds with the
audiomultipart part silently missing and nothing in the logs. This keeps the existing behavior (the report still uploads without audio rather than failing outright) and adds a warning naming the path and the exception, matching the style of the retry warning in the same function.A runnable offline repro demonstrating the silent path is in #6832; re-running it against this branch shows the warning firing with the path and the underlying errno. Happy to add a unit test asserting the warning fires if you'd like one in-tree.
🤖 Generated with Claude Code