fix(hotel_receptionist): say a refused confirm booked nothing - #6802
Open
u9g wants to merge 1 commit into
Open
Conversation
confirm_booking / confirm_reservation raised ToolError(self._status()) when a required field was still missing. _status() is progress text - it says what to do next, never that nothing was booked - and the is_error flag doesn't reach the model, because the OpenAI provider format sends the string as the whole tool message. So the refusal read as a routine step and the model went on to tell the caller they were booked, often with an invented confirmation code copied from one it had already spoken earlier in the call. Give the refusal path its own text that states the outcome first and appends _status() as context.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
ShayneP
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
confirm_booking/confirm_reservationraisedToolError(self._status())when a required field was still missing._status()is progress text — it says what to do next, never that nothing was booked — and theis_errorflag doesn't reach the model, because the OpenAI provider format sends the string as the whole tool message. So the refusal read as a routine step, and the model went on to tell the caller they were booked, often with an invented confirmation code copied from one it had already spoken earlier in the call.Both tasks now have a refusal-only string that states the outcome first and appends
_status()as context. Lifted from #6567 so it doesn't wait on that PR.Testing
.venv/bin/python -m pytest --unit(1942 passed, 5 skipped)ruff format --check/ruff checkclean on both files