Fix dbg pipeline when result renders as Kino.JS.Live #453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a pipeline with Explorer operations and
|> dbg()
hangs and times out. The pipelinec:Kino.JS.Live.init/1
callsKino.Frame.render/2
, which may result inKino.start_child/1
underneath. In the pastKino.Frame.render/2
usedGenServer.cast
, so theinit
callback would not block, finish and unlock the otherKino.start_child/1
. However, we changedKino.Frame.render/2
to useGenServer.call
(aae7a1b), so nowinit
blocks, but the nestedKino.start_child/1
hangs, untilinit
times out.To fix it, I moved
Kino.Frame.render/2
frominit
to a subsequenthandle_info
.