Tighten bound on mlist isopen asserts #921
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unbalanced open/close calls continue to be a pain point for users, it doesn't help that this sometimes results in hard-to-debug infinite loops caused by the open-file linked-list (the mlist) getting tangled up in itself. Moving the mlist isopen asserts lower into the actual list append/remove functions will help: 1. Make sure coverage of potential linked-list issues is complete. 2. Also assert against multiple close calls, which isn't an issue for the mlist, but can result in double free and memory corruption.
geky
added
enhancement
needs minor version
geky
added
next minor
and removed
needs minor version
|
It looks like this doesn't work because of the restriction of LFS_ASSERT to error-returning functions (to allow asserts to return errors). Tabling this for now. Current thinking is we should eventually split LFS_ASSERT into LFS_ASSERT and LFS_DISK_ASSERT, with only LFS_DISK_ASSERT being limited to error-returning functions. |
geky
added
needs minor version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbalanced open/close calls continue to be a pain point for users, it doesn't help that this sometimes results in hard-to-debug infinite loops caused by the open-file linked-list (the mlist) getting tangled up in itself.
Moving the mlist isopen asserts lower into the actual list append/remove functions will help:
Make sure coverage of potential linked-list issues is complete.
Also assert against multiple close calls, which isn't an issue for the mlist, but can result in double free and memory corruption.