Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated command with environment file #142

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Replace deprecated command with environment file #142

merged 1 commit into from
Sep 14, 2023

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Aug 4, 2023

Signed-off-by: jongwooo [email protected]

Description

Resolve #141

Update .github/workflows/push.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

run: echo "##[set-output name=branch;]$(echo ${GITHUB_REF##*/})"

TO-BE

run: echo "branch=$(echo ${GITHUB_REF##*/})" >> $GITHUB_OUTPUT

@Jonsy13
Copy link
Collaborator

Jonsy13 commented Aug 24, 2023

Hi @jongwooo Looks like the commits are not signed, Can you please take reference from here - https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@jongwooo
Copy link
Contributor Author

@Jonsy13 Thank you for letting me know. I signed the commit:)

@Saranya-jena Saranya-jena merged commit 30cb3ca into litmuschaos:master Sep 14, 2023
4 checks passed
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch September 14, 2023 04:59
Vr00mm pushed a commit to Vr00mm/litmusctl that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
6 participants