-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when subscriber can not get argo pod logs, make pod log message intuitive #4926
base: master
Are you sure you want to change the base?
Conversation
…nt run Signed-off-by: DongYoung Kim <[email protected]>
Signed-off-by: DongYoung Kim <[email protected]>
Signed-off-by: DongYoung Kim <[email protected]>
…Resolver Signed-off-by: DongYoung Kim <[email protected]>
Signed-off-by: DongYoung Kim <[email protected]>
Can you show us result screenshots? @kwx4957 |
yes i will add it |
Signed-off-by: DongYoung Kim <[email protected]>
func (k8s *k8sSubscriber) categorizeLogByPhase(phase string) string { | ||
switch phase { | ||
case "Completed": | ||
return "Experiment pod is deleted" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There can be a situation where users haven't added the cleanup chaos step, in that case, the experiment resources won't be deleted. We have to handle that situation as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saranya-jena I think this function will not work in that case, because it will get data from mongoDB when getting the pod logs fails, but I will test it for that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saranya-jena I remove the podGC field and the cleanup chaos step. Is this the correct procedure? The pod logs are returning as expected
Proposed changes
Fix: #4532
When subscriber pods fail to get from workflow pod or CR pod, the imported logs always return the same value. This is not intuitive for users.
So, by getting the phase state from the chaos experiment run, make the log message different for each experiment phase.
But the problem remains. I'm not sure which is the best way to write the logs.