Add more strings/texts in the strings.en.yaml file and replace all the occurences with getString() in frontend #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagnik3788 <[email protected]>
hrishavjha
approved these changes
Oct 11, 2024
hrishavjha
reviewed
Oct 11, 2024
| @@ -129,7 +129,7 @@ export function StatusHeatMap(props: StatusHeatMapProps): React.ReactElement { | |||
| {execution.executedBy?.username !== 'pipeline' ? ( | |||
| <> | |||
| {execution.executedBy?.username ?? getString('chaosController')} | |||
| {execution.executedBy?.username && ' | Manually'} | |||
| {execution.executedBy?.username && getString('manually')} | |||
There was a problem hiding this comment.
Suggested change
| {execution.executedBy?.username && getString('manually')} | |
| {execution.executedBy?.username && `| ${getString('manually')}`} |
NIT: Update strings file to just contain the text and then use in the component.
| @@ -360,6 +360,7 @@ executedBy: Executed by | |||
| executedOn: Executed on | |||
| executionDetails: Execution details goes here | |||
| executionError: Execution Error | |||
| expand: expand | |||
There was a problem hiding this comment.
Could you please clarify if there’s a specific reason this has been included, as it doesn't appear to be in use currently?
namkyu1999
added
the
need-approvers-review
|
|
S-ayanide
added
state/review-in-progress
READY-FOR-REVIEW
and removed
need-approvers-review
|
@sagnik3788 are you still working on this PR? |
|
No I am not working on it please unassign me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4147