-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add subscriber k8s fuzz test #4912
base: master
Are you sure you want to change the base?
feat: add subscriber k8s fuzz test #4912
Conversation
Signed-off-by: 잉퓨 <[email protected]>
Can you check a build pipeline? @inpyu |
Signed-off-by: 잉퓨 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first attempts. We need to use fake client for these cases because this pkg depends on kubeclient.
if KubeConfig == nil { | ||
return rest.InClusterConfig() | ||
} | ||
|
||
if *KubeConfig == "" { | ||
return rest.InClusterConfig() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if KubeConfig == nil { | |
return rest.InClusterConfig() | |
} | |
if *KubeConfig == "" { | |
return rest.InClusterConfig() | |
} | |
if *KubeConfig == "" || KubeConfig == nil { | |
return rest.InClusterConfig() | |
} |
@@ -14,11 +16,19 @@ var KubeConfig *string | |||
|
|||
// getKubeConfig setup the config for access cluster resource | |||
func (k8s *k8sSubscriber) GetKubeConfig() (*rest.Config, error) { | |||
// Use in-cluster config if kubeconfig path is not specified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you keep this line?
Signed-off-by: 잉퓨 <[email protected]>
Proposed changes
add fuzz test in /chaoscenter/graphql/server/pkg/k8s
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: