-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance YAML Formatting for Implicit Keys in mkdocs/docs #4908
Open
andoriyaprashant
wants to merge
6
commits into
litmuschaos:master
Choose a base branch
from
andoriyaprashant:implicit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andoriyaprashant
force-pushed
the
implicit
branch
from
September 30, 2024 12:01
ddf43f3
to
144d30e
Compare
Signed-off-by: andoriyaprashant <[email protected]>
ispeakc0de
reviewed
Oct 11, 2024
description: 'APIVersion defines the versioned schema of this representation | ||
of an object. Servers should convert recognized schemas to the latest | ||
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#resources' | ||
description: 'APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#resources $3 $3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the manifest for versions 3.8.0 and above while skipping changes for older versions?
namkyu1999
added
the
need-approvers-review
Reminder label to the codeowners/maintainers for stale PRs that are more that 2 weeks old
label
Nov 15, 2024
@andoriyaprashant are you still working on this PR? |
yes mam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
need-approvers-review
Reminder label to the codeowners/maintainers for stale PRs that are more that 2 weeks old
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4907
Proposed changes
This pull request resolves the issue of improper YAML formatting in the mkdocs/docs folder, where implicit keys were split across multiple lines. The affected keys have been adjusted to adhere to YAML standards by consolidating them onto single lines or using folded block scalars where appropriate. These changes eliminate parsing errors and ensure smoother documentation processing
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.