User Management Screen improvements #4454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kartikay <[email protected]>
hrishavjha
requested changes
Feb 21, 2024
| @@ -190,6 +191,13 @@ export default function AccountSettingsUserManagementView( | |||
| const { isOpen: isCreateUserModalOpen, open: openCreateUserModal, close: closeCreateUserModal } = useToggleOpen(); | |||
| const { getString } = useStrings(); | |||
|
|
|||
| const [currentPage, setCurrentPage] = useState(1); | |||
| const itemsPerPage = 5; | |||
There was a problem hiding this comment.
Users can manually set limits too, you can do something like src/controllers/ExperimentDashboardV2/ExperimentDashboardV2.tsx what done here.
There was a problem hiding this comment.
Actually I have my minors this week, would continue from next week. Apologies for delay.
There was a problem hiding this comment.
Sure no problems @kartikaysaxena, all the best for your exams.
There was a problem hiding this comment.
I have added options for the user to select the number of itemsPerPage. Should I add more options or change it into an input field or does it look fine? PTAL @hrishavjha
Screen.Recording.2024-03-06.at.7.06.21.PM.mov
There was a problem hiding this comment.
If you pass pageSizeOptions: [...new Set([10 , 20, itemsPerPage])].sort() prop to the pagination component it will render the dropdown. Rest changes looks good to me 🚀
Signed-off-by: Kartikay <[email protected]>
Saranya-jena
approved these changes
Mar 7, 2024
Signed-off-by: Kartikay <[email protected]> Signed-off-by: Kartikay <[email protected]>
…kaysaxena/litmus into usermanagment_improvements
hrishavjha
approved these changes
Mar 10, 2024
SahilKr24
requested changes
Mar 15, 2024
chaoscenter/web/src/views/AccountSettingsUserManagement/AccountSettingsUserManagement.tsx
Outdated
Show resolved
Hide resolved
chaoscenter/web/src/views/AccountSettingsUserManagement/AccountSettingsUserManagement.tsx
Outdated
Show resolved
Hide resolved
chaoscenter/web/src/views/AccountSettingsUserManagement/AccountSettingsUserManagement.tsx
Outdated
Show resolved
Hide resolved
SahilKr24
reviewed
Mar 15, 2024
chaoscenter/web/src/views/AccountSettingsUserManagement/AccountSettingsUserManagement.tsx
Outdated
Show resolved
Hide resolved
…tSettingsUserManagement.tsx Co-authored-by: Sahil <[email protected]> Signed-off-by: Kartikay <[email protected]>
…tSettingsUserManagement.tsx Co-authored-by: Sahil <[email protected]> Signed-off-by: Kartikay <[email protected]>
kartikaysaxena
force-pushed
the
usermanagment_improvements
branch
from
6014e14
to
bcd1063
Compare
…tSettingsUserManagement.tsx Co-authored-by: Sahil <[email protected]> Signed-off-by: Kartikay <[email protected]>
Signed-off-by: Kartikay <[email protected]>
kartikaysaxena
force-pushed
the
usermanagment_improvements
branch
from
bcd1063
to
b18c29c
Compare
SahilKr24
approved these changes
Apr 8, 2024
Saranya-jena
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #4450
Added pagination for user management screen.
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: