-
Notifications
You must be signed in to change notification settings - Fork 118
[documentation] Badal/fix issue 375 #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-litmuschaos ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Hi @PriteshKiri, please take a look. I cannot update the tag for the PR though. Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the comments.
Signed-off-by: badaljain <[email protected]>
ee5a24a
to
ba57652
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hey @badaljain Could you please fix the conflicts in your PR? |
Hey @badaljain Any updates? |
What this PR does / why we need it:
fixes #375
Special notes for your reviewer:
Github by default adds the underline for the main headings and thats why it was visible. Using manual span with same header size instead of markdown
#
Checklist:
documentation
tagTesting
