-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add example of utilizing GraphQL with Litestar via Strawberry #3719
Conversation
|
||
.. code-block:: shell | ||
|
||
pip install litestar[graphql] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is something that exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it as an optional dependecy in the pyproject.toml file. Should I change it to pip install strawberry-graphql
in the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not in favor adding detailed examples in the first place. I would rather prefer a link to https://strawberry.rocks/docs/integrations/litestar. I will let others weigh in on if this.
edit: I am aware of the linked issue, but I just wanted to share my opinion
Description
Add an example in the docs of how to use graphql with litestar via strawberry
Add tests for the example in
test/examples/test_graphql
Question
should I add an example of a mutation query as well?
Closes
#3317