Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop lit-analyzer from deps #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sgammon
Copy link

@sgammon sgammon commented Feb 5, 2023

  • switch to npx lit-analyzer to run
  • drops ~96 package deps, modulo env
  • drops 4 package warnings

simple change, it also alleviates the need to keep lit-analyzer up to date

- switch to `npx lit-analyzer` to run
- drops ~96 package deps, modulo env
- drops 4 package warnings
Copy link
Author

@sgammon sgammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my environment went from:

Scope: all 9 workspace projects
some/project/here                          |  WARN  deprecated [email protected]
some/project/here                          |  WARN  deprecated [email protected]
some/project/here                          |  WARN  deprecated [email protected]
some/project/here                          |  WARN  deprecated [email protected]
some/project/here                          |  WARN  deprecated [email protected]
some/project/here                          |  WARN  deprecated [email protected]

to:

Scope: all 9 workspace projects
app/ui/frontend                          |  WARN  deprecated [email protected]
app/ui/frontend                          |  WARN  deprecated [email protected]

pnpm said:

Packages: -96

@@ -12,7 +12,7 @@
"clean": "rimraf my-element.{d.ts,d.ts.map,js,js.map} test/my-element.{d.ts,d.ts.map,js,js.map} test/my-element_test.{d.ts,d.ts.map,js,js.map}",
"lint": "npm run lint:lit-analyzer && npm run lint:eslint",
"lint:eslint": "eslint 'src/**/*.ts'",
"lint:lit-analyzer": "lit-analyzer",
"lint:lit-analyzer": "npx lit-analyzer",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swap to npx...

@@ -58,7 +58,6 @@
"@web/test-runner-playwright": "^0.9.0",
"@webcomponents/webcomponentsjs": "^2.6.0",
"eslint": "^8.15.0",
"lit-analyzer": "^1.2.1",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and drop dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant