Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npm run lint on Windows #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

johnstonmatt
Copy link

npm run lint fails because eslint does not like the 's wrapping its target path. Removing the single quotes fixes npm run lint

`npm run lint` fails because eslint does not like the `'`s wrapping its target path. Removing the single quotes fixes `npm run lint`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@johnstonmatt
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@abdonrd
Copy link
Contributor

abdonrd commented Jun 10, 2020

Why doesn't work for you with the '?
I use it in a lot of projects and works well.

@johnstonmatt
Copy link
Author

johnstonmatt commented Jun 10, 2020

It may be an environment thing, certainly running npm run lint fails for this reason on my machine

@johnstonmatt
Copy link
Author

johnstonmatt commented Jun 10, 2020

I've just confirmed this is only an issue on my Windows rig, on my Mac all is well

@johnstonmatt
Copy link
Author

The fix in this PR is compatible with both of my machines, but I'll leave this to your discretion

@abdonrd
Copy link
Contributor

abdonrd commented Jun 10, 2020

Got it, you are right! Windows issue!

Copy link
Contributor

@abdonrd abdonrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, should work both!

package.json Show resolved Hide resolved
@johnstonmatt johnstonmatt changed the title remove quotes wrapping eslint path fix npm run lint on Windows Aug 11, 2020
kevinpschaaf pushed a commit that referenced this pull request Jan 6, 2021
Add <xliff> element, remove prettier formatting, release
@johnstonmatt
Copy link
Author

Should I close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants