-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --convert-dvb-subs
option.
#155
base: master
Are you sure you want to change the base?
Conversation
@ApolloniaUK Thanks for taking the time to make and submit a patch. Just out of curiosity, where are you getting input files with subtitles in DVB format? I've created at least three video transcoding projects during the last ten years and this is the first time anyone has requested a feature like this. While DVB might be an international standard, playback support for it is very poor. |
@donmelton Very happy to contribute. The input files are recordings of over-the-air DVB broadcasts in the UK. The DVR is a Mac application called EyeTV which uses a USB connected tuner called an "EyeTV Diversity" (both from a company called Geniatech). As well as Geniatech's other tuners it also supports the HD HomeRun. Not every UK DVB broadcast has subtitles but if they are present EyeTV does record them on their own stream(s). If your curiosity extends that far I could send you a sample or two. Out of interest, I also added an option to set the output filename/filepath - would you like that as well? |
@ApolloniaUK While I appreciate the effort, it's unlikely I'll take this DVB conversion feature in And I will definitely not take a patch which adds an |
Whichever way you decide thanks for considering the patch - and thanks for such a useful tool. I've been using |
…uest-branch * commit '74f5a80ce47a41e10402571f8d62181d5d656dc9': Add version 0.11.0 release information.
…uest-branch * commit '1c4782db9bf5ff9ee2d2151a57d99882f58874e1': Bump version to 0.11.0.
Hi Don, sorry to intrude.
I've made a few changes to my installation of other-transcode to meet a few local needs and I thought this one might be of wider interest.
If the
--add-subtitle
option is invoked, by default other-transcode copies the selected subtitle track(s) in their original format. If the original format is DVB Subtitle (dvb_subtitle) then this causes problems with both MP4 and MKV output formats. In the case of MP4 output the transcode fails immediately, in the case of MKV some players don't support the DVB Subtitle format. This option,--convert-dvb-subs
configures ffmpeg to convert DVB subtitles to DVD subtitles. This prevents MP4 output failing and the DVD subtitle format is supported by a wider variety of players.Hope this is of interest,
Kind regards,
Alan.