Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add colors and font styles with demos #20

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

feat: add colors and font styles with demos #20

wants to merge 12 commits into from

Conversation

b0b4456
Copy link
Contributor

@b0b4456 b0b4456 commented Dec 21, 2021

capture

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Dec 21, 2021
@b0b4456 b0b4456 changed the title add colors and font styles with demos feat: add colors and font styles with demos Dec 21, 2021
@b0b4456
Copy link
Contributor Author

b0b4456 commented Dec 21, 2021

published to https://liquality.github.io/core-lib/

Copy link
Collaborator

@adilmezghouti adilmezghouti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all the fonts here will be used. I think we should remove the ones that we don't/will not need. For example I did not see any reference to the italic ones in the designs I worked on. Anne should be able to tell us the ones we should keep.
Apart from that, everything looks good to me.

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Dec 22, 2021
Copy link
Member

@bradleySuira bradleySuira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Approved Pull Request has been approved and can be merged size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants