Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Liqoctl] interaction schema #2856

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Dec 9, 2024

Description

This PR clarifies how liqoctl interacts with Liqo.

It adds liqoctl inside the connectivity requirements schema and a new schema in the liqoctl installation page.

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@frisso
Copy link
Member

frisso commented Dec 9, 2024

This looks very good to me.
Minor comment: instead of the icon showing a person, we can use an icon showing a person behind a computer (e.g., https://uxwing.com/programmer-icon/), which makes clearer that we're referring to the programmer that is trying to get access to the cluster with Liqo.

@cheina97 cheina97 force-pushed the frc/liqoctldoc branch 3 times, most recently from 04f977f to 5887dde Compare December 10, 2024 11:45
@cheina97 cheina97 merged commit 896af81 into liqotech:master Dec 10, 2024
9 checks passed
@cheina97 cheina97 deleted the frc/liqoctldoc branch December 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants