Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E: CNI wait and retry #2133

Merged
merged 1 commit into from
Nov 10, 2023
Merged

E2E: CNI wait and retry #2133

merged 1 commit into from
Nov 10, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Nov 9, 2023

Description

This PR adds a bash function to retry a command in E2E scripts.

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 force-pushed the frc/retry branch 2 times, most recently from d2af406 to cfefa06 Compare November 9, 2023 15:04
@cheina97 cheina97 changed the title E2E: cni wait E2E: cni wait and retry Nov 9, 2023
@cheina97 cheina97 changed the title E2E: cni wait and retry E2E: CNI wait and retry Nov 9, 2023
@cheina97
Copy link
Member Author

cheina97 commented Nov 9, 2023

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Nov 9, 2023

/rebase test=true

@cheina97 cheina97 mentioned this pull request Nov 9, 2023
Merged
@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Nov 10, 2023
@adamjensenbot adamjensenbot merged commit 4fc964f into liqotech:master Nov 10, 2023
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Nov 10, 2023
@cheina97 cheina97 deleted the frc/retry branch November 10, 2023 14:41
@chenrui333 chenrui333 mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheina97 @adamjensenbot @fra98