VirtualNode: deletion-routine refactoring #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cheina97. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
cheina97
force-pushed
the
frc/deletionroutinerefactoring
branch
6 times, most recently
from
d35c720 to
f481cc2
Compare
|
I'm not sure this is a good place for these functions. Do you think pkg/utils/virtualnode or pkg/vkMachinery could be better places? |
cheina97
force-pushed
the
frc/deletionroutinerefactoring
branch
from
b9df39a to
5d6ee7a
Compare
|
/test |
aleoli
approved these changes
Sep 8, 2023
pkg/liqo-controller-manager/virtualnode-controller/virtualkubelet.go
Outdated
Show resolved
Hide resolved
pkg/liqo-controller-manager/virtualnode-controller/deletion-routine.go
Outdated
Show resolved
Hide resolved
pkg/liqo-controller-manager/virtualnode-controller/deletion-routine.go
Outdated
Show resolved
Hide resolved
pkg/liqo-controller-manager/virtualnode-controller/deletion-routine.go
Outdated
Show resolved
Hide resolved
cheina97
force-pushed
the
frc/deletionroutinerefactoring
branch
3 times, most recently
from
b7410ba to
30f35d6
Compare
aleoli
reviewed
Sep 8, 2023
pkg/liqo-controller-manager/virtualnode-controller/deletion-routine.go
Outdated
Show resolved
Hide resolved
|
/rebase test=true |
cheina97
force-pushed
the
frc/deletionroutinerefactoring
branch
3 times, most recently
from
c93c2a5 to
98209a1
Compare
|
/rebase test=true |
adamjensenbot
force-pushed
the
frc/deletionroutinerefactoring
branch
from
98209a1 to
58df128
Compare
cheina97
force-pushed
the
frc/deletionroutinerefactoring
branch
4 times, most recently
from
ecb9313 to
b5ef0ed
Compare
|
/rebase test=true |
adamjensenbot
force-pushed
the
frc/deletionroutinerefactoring
branch
from
b5ef0ed to
2ab3638
Compare
cheina97
force-pushed
the
frc/deletionroutinerefactoring
branch
from
67ad421 to
38dec0b
Compare
|
/rebase test=true |
adamjensenbot
force-pushed
the
frc/deletionroutinerefactoring
branch
from
38dec0b to
cc4c3ff
Compare
|
/rebase test=true |
1 similar comment
|
/rebase test=true |
adamjensenbot
force-pushed
the
frc/deletionroutinerefactoring
branch
from
cc4c3ff to
be6b64c
Compare
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the deletion-routine based on kubernetes guidelines https://github.com/kubernetes/community/blob/master/contributors/devel/sig-api-machinery/controllers.md