Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VirtualNode: namespacemap virtualnode selector #1977

Merged
merged 1 commit into from
Sep 8, 2023
Merged

VirtualNode: namespacemap virtualnode selector #1977

merged 1 commit into from
Sep 8, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Sep 1, 2023

Description

This PR adds support for node selector in namespace offloading, like before the introduction of the VIrtualNode API.

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 marked this pull request as draft September 1, 2023 16:13
@cheina97 cheina97 force-pushed the frc/virtualNodeSelector branch 2 times, most recently from 2d56757 to 3083e54 Compare September 1, 2023 17:02
@cheina97 cheina97 linked an issue Sep 5, 2023 that may be closed by this pull request
Namespace offloading results in liqo-controller-manager pod error: invalid memory address or nil pointer dereference #1980
Closed
@cheina97 cheina97 closed this Sep 5, 2023
@cheina97 cheina97 force-pushed the frc/virtualNodeSelector branch from 3083e54 to 7be4dfa Compare September 5, 2023 09:02
@pull-request-size pull-request-size bot added size/XS and removed size/L labels Sep 5, 2023
@cheina97 cheina97 reopened this Sep 5, 2023
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Sep 5, 2023
@cheina97 cheina97 force-pushed the frc/virtualNodeSelector branch from 7f275af to 580d0ec Compare September 5, 2023 17:35
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 5, 2023
@cheina97 cheina97 force-pushed the frc/virtualNodeSelector branch from 580d0ec to 9643f7a Compare September 5, 2023 17:57
@cheina97 cheina97 removed a link to an issue Sep 6, 2023
Namespace offloading results in liqo-controller-manager pod error: invalid memory address or nil pointer dereference #1980
Closed
@cheina97 cheina97 mentioned this pull request Sep 6, 2023
Closed
@cheina97 cheina97 marked this pull request as ready for review September 6, 2023 07:28
@cheina97 cheina97 marked this pull request as draft September 6, 2023 07:38
@cheina97 cheina97 force-pushed the frc/virtualNodeSelector branch 2 times, most recently from 45911c9 to c24f663 Compare September 6, 2023 20:35
@cheina97 cheina97 requested review from aleoli and fra98 September 7, 2023 08:05
@cheina97 cheina97 marked this pull request as ready for review September 7, 2023 08:09
@cheina97 cheina97 force-pushed the frc/virtualNodeSelector branch 2 times, most recently from a153e17 to c41c5bc Compare September 7, 2023 08:23
aleoli
aleoli reviewed Sep 7, 2023
View reviewed changes
pkg/liqoctl/completion/completion.go Outdated Show resolved Hide resolved
pkg/liqoctl/completion/completion.go Outdated Show resolved Hide resolved
pkg/liqoctl/completion/completion.go Outdated Show resolved Hide resolved
pkg/liqoctl/completion/completion.go Show resolved Hide resolved
pkg/liqo-controller-manager/namespaceoffloading-controller/namespaceoffloading_controller.go Show resolved Hide resolved
pkg/utils/virtualnode/virtualnode.go Outdated Show resolved Hide resolved
@cheina97 cheina97 force-pushed the frc/virtualNodeSelector branch from 489f7c1 to 7245246 Compare September 7, 2023 09:39
@cheina97 cheina97 force-pushed the frc/virtualNodeSelector branch 3 times, most recently from 2906238 to be62280 Compare September 7, 2023 12:20
@cheina97
Copy link
Member Author

cheina97 commented Sep 7, 2023

/test

@aleoli
Copy link
Member

aleoli commented Sep 8, 2023

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frc/virtualNodeSelector branch from be62280 to 86e014e Compare September 8, 2023 09:26
@aleoli
Copy link
Member

aleoli commented Sep 8, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 8, 2023
@adamjensenbot adamjensenbot merged commit 1500ed8 into liqotech:master Sep 8, 2023
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 8, 2023
@cheina97 cheina97 deleted the frc/virtualNodeSelector branch September 8, 2023 10:23
@krehel krehel mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@fra98 fra98 Awaiting requested review from fra98

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheina97 @adamjensenbot @aleoli