-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update header #86
Update header #86
Conversation
I like it a lot :) I think it solves a few nice problems like
I think
|
one way of doing active state: https://sometimes.digital/posts/highlighting-the-active-navigation-link-in-eleventy/ another could be to expose a piece of data on each page like |
Thanks for the documentation about how to do active links, that's very helpful! I'm not planning on working on that as part of this PR, but definitely in the future. |
I like it :) Thanks for the changes! A few notes:
For me, I would be happy to merge this without solving 1, 3, and 4 yet. They can be separate issues. However, I am not a fan of the Patreon link in the header. I think it is jarring to click around. What do you think? |
hey! I'd like to merge this as it is nice, but I'd like to move the Patreon link somewhere else (or leave it in the "popup" as it currently is) - what do you think? |
Hey @alifeee, here are some options off the top of my head for dealing with the Patreon link:
Thoughts? |
I like 3 and 4. Personally, I support having only as many pages as necessary, so I suggest we can have only:
the patreon link can be put on the homepage or sona page, and the "lipu ante" can also be put on the sona page (the links on there are massively outdated, so not really deserving of their own page) One note is that lipu tenpo's goal at the moment is to find more writers/artists/proofreaders/layouters. In my opinion, promoting Patreon is not massively important in contrast (we have a good number on there. ... especially as more people on print+post means I have to pack more envelopes 😄) what do you think of this suggestion of having only 3 pages? |
I have made some changes. View the site on https://liputenpotest.alifeee.co.uk/ :) |
if sticking with the removal of lipu-ante, a redirect should be made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping in here @alifeee ! Removing lipu ante and Patreon from the main menu makes sense to me. I have a couple of suggestions but otherwise this looks good to me!
surge: deployed to https://liputenpotest-86.surge.sh |
thanks for the review! I think it is nearly ready to merge, jan Alonola was saying that the left-align of the header felt weird. I think you were saying how you think it is better, and you were thinking of left-aligning more of the content? I hope the deploy preview works for you! |
@alifeee the left alignment does look a little weird on larger screens given that the rest of the content is centered at the moment. My suggestion would be to keep it left-aligned but within a container that is centered on the page and has a maximum width. Does that make sense? |
I think that's a great idea the homepage big-list is limited to most of the sona page (text) and the so we already have this in some places, it would be a good help with the header |
super! thanks for updating :) I think this is a great change now! Just playing around with some final centering, as now the menu items are different heights it looks a little jarring to me that they're all top-aligned. What do you think of this comparison? original centred also, what do you think of "lipu" -> "lipu ale" (I think it could be nice as it makes the headings more similar heights) my apologies if I'm drawing out this PR! I would also be happy to merge this as-is, as the "stepped" nature of the headings does knock up against the top right corner, so fits fine I'd love if you provided a review and we can get it merged ! :) |
I realise (I think) you cannot provide a "review". a comment will do :) |
@alifeee I'm in favor of lipu ale rather than lipu. Another option might be tomo lipu since it is also the homepage. I'm less sure of the vertical centering, I think it looks good but legibility might be better when they all start at the same baseline. My suggestion is that I update the link text and keep the alignment for now and we can make that a separate issue. |
thank you so much @ngsilverman !!! let me know if I was too opinionated, but I think we've ended up with something we're all pretty happy with(?) |
Awesome! Thanks for working with me on this @alifeee, I appreciate you! sina pona tawa mi a! |
I think the current header is pretty busy and pretty big. With this first change I'm hoping to shift the focus back on the most important elements: the title of the publication, the main menu, and the rest of the content. I want to be clear that I don't love this new design I'm proposing, but I think it's an improvement, and that it creates a solid foundation to further improve upon in the near future.
A few notes:
Some possible further improvements I'm already thinking of:
And, of course, I'm open to requests and feedback!