Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ptv wip #139

Draft
wants to merge 26 commits into
base: type-code-renewal-3
Choose a base branch
from
Draft

Ptv wip #139

wants to merge 26 commits into from

Conversation

Deraen
Copy link
Collaborator

@Deraen Deraen commented Nov 4, 2024

No description provided.

@Deraen Deraen changed the base branch from master to type-code-renewal-3 November 4, 2024 15:04
Comment on lines +135 to +136
;; Might include (some) of the UTP data now?
;; Could be a good thing, but might make the prompt data too large?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually looks like I've considered UTP data here.. Since dissoc contains videos and images that are clearly UTP stuff. However, it might be good to review if there are keys that:

  • don't provide clear value for text generation
  • can make the payload too large for the AI

I think :ptv should be dissoc'd also... since it contains only identifiers and previously generated texts.

Also, some of the UTP-fields may contain very long texts...

- Store created ServiceLocation ID to DB directly in the BE (previously
  sent to UI and them MAYBE stored to DB at some later time, if user
  did some operations in right order)
- Return same data to UI for autocomplete listing for created
  ServiceLocations, as the list endpoint returns
- Retry http request if token expired (or something)
Rename the global fn so it isn't accidentally used instead of version
with partially bounds args.
- Set PTV publishing status based on Lipas status
- Store PTV publishing status under :ptv meta so we can detect if Lipas
  deleted was already deleted in PTV also
and create new PTV site if updated so site looks like PTV candidate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants