Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use boto3 clients rather than resources TDE-1034 #1172

Merged
merged 5 commits into from
Nov 24, 2024
Merged

refactor: Use boto3 clients rather than resources TDE-1034 #1172

merged 5 commits into from
Nov 24, 2024

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Nov 15, 2024

Motivation

The latter is deprecated
https://boto3.amazonaws.com/v1/documentation/api/1.35.60/guide/resources.html.

Modifications

  • Use the lower-level clients API instead of resources.
  • Type annotate S3 clients to make IDE use easier.

Verification

Standard tests.

@l0b0 l0b0 requested a review from a team as a code owner November 15, 2024 03:02
@l0b0 l0b0 enabled auto-merge November 15, 2024 03:02
paulfouquet
paulfouquet reviewed Nov 17, 2024
View reviewed changes
scripts/files/fs_s3.py Outdated Show resolved Hide resolved
@l0b0 l0b0 requested a review from paulfouquet November 24, 2024 21:43
@l0b0 l0b0 added this pull request to the merge queue Nov 24, 2024
Merged via the queue into master with commit ffe7f90 Nov 24, 2024
2 checks passed
@l0b0 l0b0 deleted the refactor/boto3-client-instead-of-resource-tde-1034 branch November 24, 2024 21:49
@paulfouquet paulfouquet added the container Publish a container label Nov 27, 2024
@paulfouquet paulfouquet restored the refactor/boto3-client-instead-of-resource-tde-1034 branch November 27, 2024 23:58
@paulfouquet paulfouquet added container Publish a container and removed container Publish a container labels Nov 27, 2024
@l0b0 l0b0 mentioned this pull request Nov 28, 2024
Merged
@l0b0 l0b0 deleted the refactor/boto3-client-instead-of-resource-tde-1034 branch November 28, 2024 00:58
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2024
@l0b0
fix: Use client syntax for getting file contents (#1194)
ab83041 
### Motivation

Missing update from #1172.

### Verification

Untested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfouquet paulfouquet paulfouquet approved these changes

@schmidtnz schmidtnz Awaiting requested review from schmidtnz schmidtnz is a code owner automatically assigned from linz/li-topo-data-engineering

@amfage amfage Awaiting requested review from amfage amfage is a code owner automatically assigned from linz/li-topo-data-engineering

@MDavidson17 MDavidson17 Awaiting requested review from MDavidson17 MDavidson17 is a code owner automatically assigned from linz/li-topo-data-engineering

Assignees
No one assigned
Labels
container Publish a container
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l0b0 @paulfouquet