Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add screenshot tests for the topo-raster tileset BM-1167 #424

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

tawera-manaena
Copy link
Contributor

@tawera-manaena tawera-manaena commented Jan 16, 2025

Motivation

As a Basemaps developer, I want screenshot tests that capture changes to the Basemaps NZ Topo Gridless Maps layer (topo-raster tileset). We anticipate refactoring the process that generate the layer's imagery. We will undertake such refactoring efforts when we come to support additional Map Series datasets, such as:

Having these tests will help us automatically identify artifact concerns and unanticipated changes that may arise due to changes to the imagery generation process.

Modifications

This work adds three new screenshot tests:

nz-topo-gridless-maps-2193-nz-250k-z4
Verifies the absence of black edge artifacts around the imagery's perimeter [1].
nz-topo-gridless-maps-3857-chatham-islands-250k-z10
Verifies the location and re-projection of the Chatham Islands imagery from EPSG:3793 to EPSG:3857 [2].
nz-topo-gridless-maps-3857-wellington-50k-z12
Verifies the tileset displays the 50k imagery as defined in the tileset's definition [3].

Verification

I have verified the added screenshot tests locally. I used the following commands to install the required dependencies and compile the source code:

# install dependencies
npm install

# compile the source code
npm run build

I then used the following command to run the screenshot process:

# run the screenshot process
node build/src/bin.js --url basemaps.linz.govt.nz --output screenshot-folder/

The process captures the added screenshot tests and saves them to the output location without issue.

@tawera-manaena tawera-manaena changed the title feat: add screenshot tests for the topo-raster tileset feat: add screenshot tests for the topo-raster tileset BM-1167 Jan 16, 2025
src/tiles.ts Outdated Show resolved Hide resolved
src/tiles.ts Outdated Show resolved Hide resolved
@tawera-manaena tawera-manaena marked this pull request as ready for review January 16, 2025 03:06
@tawera-manaena tawera-manaena requested a review from a team as a code owner January 16, 2025 03:06
@Wentao-Kuang Wentao-Kuang force-pushed the feat/topo-raster-map-screenshots branch from 62a2bad to e94a5e4 Compare January 16, 2025 21:55
@Wentao-Kuang Wentao-Kuang added the automerge 🚀 Automatically merge a branch using kodiak label Jan 16, 2025
@Wentao-Kuang Wentao-Kuang added this pull request to the merge queue Jan 16, 2025
Merged via the queue into master with commit 5acff1e Jan 16, 2025
4 of 5 checks passed
@blacha blacha deleted the feat/topo-raster-map-screenshots branch January 21, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge 🚀 Automatically merge a branch using kodiak
Development

Successfully merging this pull request may close these issues.

2 participants