feat: add screenshot tests for the topo-raster tileset BM-1167 #424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a Basemaps developer, I want screenshot tests that capture changes to the Basemaps NZ Topo Gridless Maps layer (
topo-raster
tileset). We anticipate refactoring the process that generate the layer's imagery. We will undertake such refactoring efforts when we come to support additional Map Series datasets, such as:Having these tests will help us automatically identify artifact concerns and unanticipated changes that may arise due to changes to the imagery generation process.
Modifications
This work adds three new screenshot tests:
nz-topo-gridless-maps-2193-nz-250k-z4
nz-topo-gridless-maps-3857-chatham-islands-250k-z10
EPSG:3793
toEPSG:3857
[2].nz-topo-gridless-maps-3857-wellington-50k-z12
Verification
I have verified the added screenshot tests locally. I used the following commands to install the required dependencies and compile the source code:
I then used the following command to run the screenshot process:
# run the screenshot process node build/src/bin.js --url basemaps.linz.govt.nz --output screenshot-folder/
The process captures the added screenshot tests and saves them to the output location without issue.