Skip to content

feat: add DAL (CM-951) #3836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ulemons wants to merge 1 commit into
base: feat/add-project-discovery-worker
Choose a base branch
from
+810 −0
Open

feat: add DAL (CM-951) #3836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
397 changes: 397 additions & 0 deletions services/libs/data-access-layer/src/evaluated-projects/evaluatedProjects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,397 @@
import { QueryExecutor } from '../queryExecutor'
import { prepareSelectColumns } from '../utils'

import {
EvaluationStatus,
IDbEvaluatedProject,
IDbEvaluatedProjectCreate,
IDbEvaluatedProjectUpdate,
} from './types'

const EVALUATED_PROJECT_COLUMNS = [
'id',
'projectCatalogId',
'evaluationStatus',
'evaluationScore',
'evaluation',
'evaluationReason',
'evaluatedAt',
'starsCount',
'forksCount',
'commitsCount',
'pullRequestsCount',
'issuesCount',
'onboarded',
'onboardedAt',
'createdAt',
'updatedAt',
]

export async function findEvaluatedProjectById(
qx: QueryExecutor,
id: string,
): Promise<IDbEvaluatedProject | null> {
return qx.selectOneOrNone(
`
SELECT ${prepareSelectColumns(EVALUATED_PROJECT_COLUMNS)}
FROM "evaluatedProjects"
WHERE id = $(id)
`,
{ id },
)
}

export async function findEvaluatedProjectByProjectCatalogId(
qx: QueryExecutor,
projectCatalogId: string,
): Promise<IDbEvaluatedProject | null> {
return qx.selectOneOrNone(
`
SELECT ${prepareSelectColumns(EVALUATED_PROJECT_COLUMNS)}
FROM "evaluatedProjects"
WHERE "projectCatalogId" = $(projectCatalogId)
`,
{ projectCatalogId },
)
}

export async function findEvaluatedProjectsByStatus(
qx: QueryExecutor,
evaluationStatus: EvaluationStatus,
options: { limit?: number; offset?: number } = {},
): Promise<IDbEvaluatedProject[]> {
const { limit, offset } = options

return qx.select(
`
SELECT ${prepareSelectColumns(EVALUATED_PROJECT_COLUMNS)}
FROM "evaluatedProjects"
WHERE "evaluationStatus" = $(evaluationStatus)
ORDER BY "createdAt" ASC
${limit !== undefined ? 'LIMIT $(limit)' : ''}
${offset !== undefined ? 'OFFSET $(offset)' : ''}
`,
{ evaluationStatus, limit, offset },
)
}

export async function findAllEvaluatedProjects(
qx: QueryExecutor,
options: { limit?: number; offset?: number } = {},
): Promise<IDbEvaluatedProject[]> {
const { limit, offset } = options

return qx.select(
`
SELECT ${prepareSelectColumns(EVALUATED_PROJECT_COLUMNS)}
FROM "evaluatedProjects"
ORDER BY "createdAt" DESC
${limit !== undefined ? 'LIMIT $(limit)' : ''}
${offset !== undefined ? 'OFFSET $(offset)' : ''}
`,
{ limit, offset },
)
}

export async function countEvaluatedProjects(
qx: QueryExecutor,
evaluationStatus?: EvaluationStatus,
): Promise<number> {
const statusFilter = evaluationStatus ? 'WHERE "evaluationStatus" = $(evaluationStatus)' : ''

const result = await qx.selectOne(
`
SELECT COUNT(*) AS count
FROM "evaluatedProjects"
${statusFilter}
`,
{ evaluationStatus },
)
return parseInt(result.count, 10)
}

export async function insertEvaluatedProject(
qx: QueryExecutor,
data: IDbEvaluatedProjectCreate,
): Promise<IDbEvaluatedProject> {
return qx.selectOne(
`
INSERT INTO "evaluatedProjects" (
"projectCatalogId",
"evaluationStatus",
"evaluationScore",
evaluation,
"evaluationReason",
"starsCount",
"forksCount",
"commitsCount",
"pullRequestsCount",
"issuesCount",
"createdAt",
"updatedAt"
)
Comment on lines +119 to +132
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insertEvaluatedProject ignores onboarded, onboardedAt, and evaluatedAt even though they are part of the writable model/type. This can lead to unexpected behavior if callers pass these fields (they'll be silently dropped). Include these columns in the INSERT (or remove them from the create type if they should only be set via dedicated update helpers).

Copilot uses AI. Check for mistakes.
VALUES (
$(projectCatalogId),
$(evaluationStatus),
$(evaluationScore),
$(evaluation),
$(evaluationReason),
$(starsCount),
$(forksCount),
$(commitsCount),
$(pullRequestsCount),
$(issuesCount),
NOW(),
NOW()
)
RETURNING ${prepareSelectColumns(EVALUATED_PROJECT_COLUMNS)}
`,
{
projectCatalogId: data.projectCatalogId,
evaluationStatus: data.evaluationStatus ?? 'pending',
evaluationScore: data.evaluationScore ?? null,
evaluation: data.evaluation ? JSON.stringify(data.evaluation) : null,
evaluationReason: data.evaluationReason ?? null,
starsCount: data.starsCount ?? null,
forksCount: data.forksCount ?? null,
commitsCount: data.commitsCount ?? null,
pullRequestsCount: data.pullRequestsCount ?? null,
issuesCount: data.issuesCount ?? null,
},
)
}

export async function bulkInsertEvaluatedProjects(
qx: QueryExecutor,
items: IDbEvaluatedProjectCreate[],
): Promise<void> {
if (items.length === 0) {
return
}

const values = items.map((item) => ({
projectCatalogId: item.projectCatalogId,
evaluationStatus: item.evaluationStatus ?? 'pending',
evaluationScore: item.evaluationScore ?? null,
evaluation: item.evaluation ? JSON.stringify(item.evaluation) : null,
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In bulkInsertEvaluatedProjects, values pre-serializes evaluation with JSON.stringify(...), but the SQL recordset defines evaluation jsonb. This will cause the inserted JSONB to become a JSON string (or fail coercion), rather than storing the object. Pass the evaluation object directly in values (let JSON.stringify only happen once for the whole values payload) and keep the SQL cast to jsonb.

Suggested change
evaluation: item.evaluation ? JSON.stringify(item.evaluation) : null,
evaluation: item.evaluation ?? null,

Copilot uses AI. Check for mistakes.
evaluationReason: item.evaluationReason ?? null,
starsCount: item.starsCount ?? null,
forksCount: item.forksCount ?? null,
commitsCount: item.commitsCount ?? null,
pullRequestsCount: item.pullRequestsCount ?? null,
issuesCount: item.issuesCount ?? null,
}))

await qx.result(
`
INSERT INTO "evaluatedProjects" (
"projectCatalogId",
"evaluationStatus",
"evaluationScore",
evaluation,
"evaluationReason",
"starsCount",
"forksCount",
"commitsCount",
"pullRequestsCount",
"issuesCount",
"createdAt",
"updatedAt"
)
SELECT
v."projectCatalogId"::uuid,
v."evaluationStatus",
v."evaluationScore"::double precision,
v.evaluation::jsonb,
v."evaluationReason",
v."starsCount"::integer,
v."forksCount"::integer,
v."commitsCount"::integer,
v."pullRequestsCount"::integer,
v."issuesCount"::integer,
NOW(),
NOW()
FROM jsonb_to_recordset($(values)::jsonb) AS v(
"projectCatalogId" text,
"evaluationStatus" text,
"evaluationScore" double precision,
evaluation jsonb,
"evaluationReason" text,
"starsCount" integer,
"forksCount" integer,
"commitsCount" integer,
"pullRequestsCount" integer,
"issuesCount" integer
)
`,
{ values: JSON.stringify(values) },
)
}

export async function updateEvaluatedProject(
qx: QueryExecutor,
id: string,
data: IDbEvaluatedProjectUpdate,
): Promise<IDbEvaluatedProject | null> {
const setClauses: string[] = []
const params: Record<string, unknown> = { id }

if (data.evaluationStatus !== undefined) {
setClauses.push('"evaluationStatus" = $(evaluationStatus)')
params.evaluationStatus = data.evaluationStatus
}
if (data.evaluationScore !== undefined) {
setClauses.push('"evaluationScore" = $(evaluationScore)')
params.evaluationScore = data.evaluationScore
}
if (data.evaluation !== undefined) {
setClauses.push('evaluation = $(evaluation)')
params.evaluation = data.evaluation ? JSON.stringify(data.evaluation) : null
}
if (data.evaluationReason !== undefined) {
setClauses.push('"evaluationReason" = $(evaluationReason)')
params.evaluationReason = data.evaluationReason
}
if (data.evaluatedAt !== undefined) {
setClauses.push('"evaluatedAt" = $(evaluatedAt)')
params.evaluatedAt = data.evaluatedAt
}
if (data.starsCount !== undefined) {
setClauses.push('"starsCount" = $(starsCount)')
params.starsCount = data.starsCount
}
if (data.forksCount !== undefined) {
setClauses.push('"forksCount" = $(forksCount)')
params.forksCount = data.forksCount
}
if (data.commitsCount !== undefined) {
setClauses.push('"commitsCount" = $(commitsCount)')
params.commitsCount = data.commitsCount
}
if (data.pullRequestsCount !== undefined) {
setClauses.push('"pullRequestsCount" = $(pullRequestsCount)')
params.pullRequestsCount = data.pullRequestsCount
}
if (data.issuesCount !== undefined) {
setClauses.push('"issuesCount" = $(issuesCount)')
params.issuesCount = data.issuesCount
}
if (data.onboarded !== undefined) {
setClauses.push('onboarded = $(onboarded)')
params.onboarded = data.onboarded
}
if (data.onboardedAt !== undefined) {
setClauses.push('"onboardedAt" = $(onboardedAt)')
params.onboardedAt = data.onboardedAt
}

if (setClauses.length === 0) {
return findEvaluatedProjectById(qx, id)
}

return qx.selectOneOrNone(
`
UPDATE "evaluatedProjects"
SET
${setClauses.join(',\n ')},
"updatedAt" = NOW()
WHERE id = $(id)
RETURNING ${prepareSelectColumns(EVALUATED_PROJECT_COLUMNS)}
`,
params,
)
}

export async function markEvaluatedProjectAsEvaluated(
qx: QueryExecutor,
id: string,
data: {
evaluationScore: number
evaluation: Record<string, unknown>
evaluationReason?: string
},
): Promise<IDbEvaluatedProject | null> {
return qx.selectOneOrNone(
`
UPDATE "evaluatedProjects"
SET
"evaluationStatus" = 'evaluated',
"evaluationScore" = $(evaluationScore),
evaluation = $(evaluation),
"evaluationReason" = $(evaluationReason),
"evaluatedAt" = NOW(),
"updatedAt" = NOW()
WHERE id = $(id)
RETURNING ${prepareSelectColumns(EVALUATED_PROJECT_COLUMNS)}
`,
{
id,
evaluationScore: data.evaluationScore,
evaluation: JSON.stringify(data.evaluation),
evaluationReason: data.evaluationReason ?? null,
},
)
}

export async function markEvaluatedProjectAsOnboarded(
qx: QueryExecutor,
id: string,
): Promise<void> {
await qx.selectNone(
`
UPDATE "evaluatedProjects"
SET
onboarded = true,
"onboardedAt" = NOW(),
"updatedAt" = NOW()
WHERE id = $(id)
`,
{ id },
)
}

export async function deleteEvaluatedProject(qx: QueryExecutor, id: string): Promise<number> {
return qx.result(
`
DELETE FROM "evaluatedProjects"
WHERE id = $(id)
`,
{ id },
)
}

export async function deleteEvaluatedProjectByProjectCatalogId(
qx: QueryExecutor,
projectCatalogId: string,
): Promise<number> {
return qx.result(
`
DELETE FROM "evaluatedProjects"
WHERE "projectCatalogId" = $(projectCatalogId)
`,
{ projectCatalogId },
)
}

export async function findPendingEvaluatedProjectsWithCatalog(
qx: QueryExecutor,
options: { limit?: number } = {},
): Promise<(IDbEvaluatedProject & { projectSlug: string; repoName: string; repoUrl: string })[]> {
const { limit } = options

return qx.select(
`
SELECT
${prepareSelectColumns(EVALUATED_PROJECT_COLUMNS, 'ep')},
pc."projectSlug",
pc."repoName",
pc."repoUrl"
FROM "evaluatedProjects" ep
JOIN "projectCatalog" pc ON pc.id = ep."projectCatalogId"
WHERE ep."evaluationStatus" = 'pending'
ORDER BY ep."createdAt" ASC
${limit !== undefined ? 'LIMIT $(limit)' : ''}
`,
{ limit },
)
}
Loading
Loading