Support Debian i386 in CI #53
Conversation
|
Hello @TheAssassin, Can you have a look on this PR, please? |
| include: | ||
| - gtk-version: gtk3 | ||
| linux-distro: debian | ||
| arch: 386 |
There was a problem hiding this comment.
i386 would be more idiomatic, would not be interpreted as an int by accident and also is in line with Debian's architecture naming (amd64 is, too), which might make some things more straightforward.
There was a problem hiding this comment.
386 is the arch of the image: https://hub.docker.com/layers/library/debian/buster/images/sha256-abea34421f483e6dfe65a4f7d5267124a5de9b53e522c27bc9eb935644229ecb?context=explore
We cannot change it.
There was a problem hiding this comment.
I see. I've always used the i386/debian image. These prefixes are clearly inspired by Debian. I don't mind using 386 then. Maybe it should be put in quotes, though, to make sure it's considered a string.
There was a problem hiding this comment.
Well, it seems i386 is also valid and pulls the correct image. Let's see CI result with bba4017 then.
There was a problem hiding this comment.
Run buildah bud --arch="${ARCHITECTURE}" --build-arg MACHINE="${MACHINE}" --tag "${IMAGE_NAME}" --file "containers/${GTK_VERSION}/Dockerfile.${LINUX_DISTRO}" .
[1/2] STEP 1/13: FROM docker.io/debian:buster AS build-stage
Trying to pull docker.io/library/debian:buster...
error creating build container: choosing an image from manifest list docker://debian:buster: no image found in manifest list for architecture i386, variant "", OS linux
[2/2] STEP 1/7: FROM docker.io/debian:buster
time="2023-09-17T12:41:48Z" level=error msg="exit status 125"
Error: Process completed with exit code 125.
Nope, i386 is not understood by Buildah.
There was a problem hiding this comment.
I really don't insist on it. Your first attempt worked fine. I was just a bit curious on why it was that value specifically.
| - name: Set extra environment variables | ||
| run: | | ||
| case "${ARCHITECTURE}" in | ||
| 386) echo MACHINE="i386" >> "$GITHUB_ENV";; |
There was a problem hiding this comment.
If you change 386 to i386, you can just have a default case to set MACHINE to $ARCHITECTURE.
|
Sorry for the long time to this review. I was quite busy in the last months. |
Do not worry, I did not remember me neither. |
TheTumultuousUnicornOfDarkness
force-pushed
the
ci_debian_i386
branch
from
bba4017 to
b970f24
Compare
|
It was not working with |
|
Thanks! |
As suggested by @rmartin16 in #52, it would be better to support i386 (when available) in order to avoid issue like #50.
This PR adds a new
archfield in the matrix that can be extended thanks to thejobs.<job_id>.strategy.matrix.includekeyword. Only Debian still support i386, so there are 4 jobs for Debian (GTK3/4 i386/amd64) but no changes for other distro.