fix: crashed on palette destroyed #385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kegechen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 21, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#385
|
TAG Bot New tag: 5.6.34 |
|
Doc Check bot |
kegechen
force-pushed
the
toolitips_crash
branch
from
594998f
to
b484632
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#385
kegechen
force-pushed
the
toolitips_crash
branch
from
b484632
to
5c7d6c5
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#385
kegechen
force-pushed
the
toolitips_crash
branch
from
5c7d6c5
to
c6f52aa
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#385
kegechen
force-pushed
the
toolitips_crash
branch
from
c6f52aa
to
9178e99
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 26, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#385
zccrs
requested changes
Aug 26, 2024
kegechen
force-pushed
the
toolitips_crash
branch
from
9178e99
to
d7db04f
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 27, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#385
kegechen
force-pushed
the
toolitips_crash
branch
from
d7db04f
to
ac94025
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 27, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#385
kegechen
commented
Aug 27, 2024
src/private/dquickcontrolpalette.cpp
Outdated
| @@ -937,7 +938,7 @@ void DQuickControlColorSelector::notifyColorPropertyChanged() | |||
|
|
|||
| void DQuickControlColorSelector::updatePropertyFromName(const QByteArray &name, const DQuickControlPalette *palette) | |||
| { | |||
| if (QCoreApplication::closingDown()) | |||
| if (QCoreApplication::closingDown() || DQMLGlobalObjectPrivate::g_appAboutToQuit) | |||
There was a problem hiding this comment.
closingDown 太晚了，，aboutToQuit 时就应该停止了
There was a problem hiding this comment.
用 QCoreApplicationPrivate::aboutToQuitEmitted 做判断行不行？
There was a problem hiding this comment.
用 QCoreApplicationPrivate::aboutToQuitEmitted 做判断行不行？
可以，不过需要用 #define protected public 黑魔法
kegechen
force-pushed
the
toolitips_crash
branch
from
ac94025
to
7e4be18
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Sep 9, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#385
deepin pr auto review关键摘要:
是否建议立即修改:
|
|
TAG Bot New tag: 5.0.35 |
kegechen
force-pushed
the
toolitips_crash
branch
from
7e4be18
to
9b8d669
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Oct 16, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#385
zccrs
requested changes
Oct 17, 2024
src/private/dquickcontrolpalette.cpp
Outdated
| @@ -937,7 +938,7 @@ void DQuickControlColorSelector::notifyColorPropertyChanged() | |||
|
|
|||
| void DQuickControlColorSelector::updatePropertyFromName(const QByteArray &name, const DQuickControlPalette *palette) | |||
| { | |||
| if (QCoreApplication::closingDown()) | |||
| if (QCoreApplication::closingDown() || DQMLGlobalObjectPrivate::g_appAboutToQuit) | |||
There was a problem hiding this comment.
用 QCoreApplicationPrivate::aboutToQuitEmitted 做判断行不行？
kegechen
force-pushed
the
toolitips_crash
branch
from
9b8d669
to
3b53f8e
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Oct 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#385
do not set value if app is about to quit Issue: linuxdeepin/dtk#193
kegechen
force-pushed
the
toolitips_crash
branch
from
3b53f8e
to
a4a4640
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Oct 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#385
18202781743
reviewed
Oct 22, 2024
| @@ -937,7 +941,9 @@ void DQuickControlColorSelector::notifyColorPropertyChanged() | |||
|
|
|||
| void DQuickControlColorSelector::updatePropertyFromName(const QByteArray &name, const DQuickControlPalette *palette) | |||
| { | |||
| if (QCoreApplication::closingDown()) | |||
| auto appriv = static_cast<QCoreApplicationPrivate*>(qApp->QCoreApplication::d_ptr.data()); | |||
There was a problem hiding this comment.
auto prv = dynamic_cast<QCoreApplicationPrivate *>(QObjectPrivate::get(qApp));
qDebug() << prv->aboutToQuitEmitted;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not set value if control's window is null
Issue: linuxdeepin/dtk#193