Skip to content

fix(loader): enable screen recorder tray plugins on Treeland - #538

Open
dengzhongyuan365-dev wants to merge 1 commit into
linuxdeepin:masterfrom
dengzhongyuan365-dev:fix/treeland-enable-recorder-plugins
Open

dengzhongyuan365-dev wants to merge 1 commit into
linuxdeepin:masterfrom
dengzhongyuan365-dev:fix/treeland-enable-recorder-plugins

Conversation

@dengzhongyuan365-dev

@dengzhongyuan365-dev dengzhongyuan365-dev commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Allow the screen recorder tray plugins to load in Treeland so the recording timer and recorder entry are available.

允许录屏托盘插件在 Treeland 下加载,恢复录屏计时和录屏入口。

Log: 放开 Treeland 录屏托盘插件
PMS: TASK-393987
Influence: Treeland 会话下录屏时会显示托盘计时,并恢复录屏入口插件。

Summary by Sourcery

Enable screen recorder tray plugins for Treeland sessions while retaining the existing Wayland plugin restrictions.

New Features:

  • Enable the screen recorder tray and recording entry plugins in Treeland sessions.

Bug Fixes:

  • Restore the recording timer and recorder entry in the Treeland tray.

@sourcery-ai

sourcery-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Implementation

Remove the two screen recorder plugins from the Wayland blacklist so they can load in Treeland sessions.

  • src/loader/pluginmanager.cpp L75 (removed lines)

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="src/loader/pluginmanager.cpp" line_range="75" />
<code_context>
     // TODO: use dconfig for this purpose.
     if (qgetenv("XDG_SESSION_TYPE") == "wayland") {
         blacklistedPluginPaths.append(QStringList{
-            "libshot-start-record-plugin.so",
-            "libdeepin-screen-recorder-plugin.so",
             "libeye-comfort-mode.so",
</code_context>
<issue_to_address>
**Recorder entries appear outside Treeland**

When the loader runs in a non-Treeland Wayland session, `PluginManager::loadPlugin` loads both recorder plugins there, exposing recorder tray entries outside the target session.

Keep both recorder plugin paths excluded from non-Treeland Wayland sessions.

Also at `src/loader/pluginmanager.cpp:76`.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread src/loader/pluginmanager.cpp Resolved
Allow the screen recorder tray plugins to load in Treeland so the
recording timer and recorder entry are available.

允许录屏托盘插件在 Treeland 下加载,恢复录屏计时和录屏入口。

Log: 放开 Treeland 录屏托盘插件
PMS: TASK-393987
Influence: Treeland 会话下录屏时会显示托盘计时,并恢复录屏入口插件。
@dengzhongyuan365-dev
dengzhongyuan365-dev force-pushed the fix/treeland-enable-recorder-plugins branch from 3fdddcd to 868f030 Compare November 13, 2026 06:26
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次变更从 Wayland 会话的插件黑名单中移除录屏相关插件(libshot-start-record-plugin.so 和 libdeepin-screen-recorder-plugin.so),使其在 Treeland 下可正常加载。变更最小化且聚焦, 语法正确、逻辑清晰,无安全漏洞,四维度均通过。启发式扫描与 OCR 审查均未发现问题。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: []


💡 改进建议代码示例


本报告由 AI 代码审查工具自动生成

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, dengzhongyuan365-dev

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dengzhongyuan365-dev

Copy link
Copy Markdown
Member Author

/merge

@deepin-bot

deepin-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

This pr cannot be merged! (status: unstable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants