Repository navigation
fix(loader): enable screen recorder tray plugins on Treeland - #538
dengzhongyuan365-dev wants to merge 1 commit into
Conversation
Reviewer's GuideImplementationRemove the two screen recorder plugins from the Wayland blacklist so they can load in Treeland sessions.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/loader/pluginmanager.cpp" line_range="75" />
<code_context>
// TODO: use dconfig for this purpose.
if (qgetenv("XDG_SESSION_TYPE") == "wayland") {
blacklistedPluginPaths.append(QStringList{
- "libshot-start-record-plugin.so",
- "libdeepin-screen-recorder-plugin.so",
"libeye-comfort-mode.so",
</code_context>
<issue_to_address>
**Recorder entries appear outside Treeland**
When the loader runs in a non-Treeland Wayland session, `PluginManager::loadPlugin` loads both recorder plugins there, exposing recorder tray entries outside the target session.
Keep both recorder plugin paths excluded from non-Treeland Wayland sessions.
Also at `src/loader/pluginmanager.cpp:76`.
</issue_to_address>Allow the screen recorder tray plugins to load in Treeland so the recording timer and recorder entry are available. 允许录屏托盘插件在 Treeland 下加载,恢复录屏计时和录屏入口。 Log: 放开 Treeland 录屏托盘插件 PMS: TASK-393987 Influence: Treeland 会话下录屏时会显示托盘计时,并恢复录屏入口插件。
3fdddcd to
868f030
Compare
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: [] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例本报告由 AI 代码审查工具自动生成 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, dengzhongyuan365-dev The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/merge |
|
This pr cannot be merged! (status: unstable) |
Allow the screen recorder tray plugins to load in Treeland so the recording timer and recorder entry are available.
允许录屏托盘插件在 Treeland 下加载,恢复录屏计时和录屏入口。
Log: 放开 Treeland 录屏托盘插件
PMS: TASK-393987
Influence: Treeland 会话下录屏时会显示托盘计时,并恢复录屏入口插件。
Summary by Sourcery
Enable screen recorder tray plugins for Treeland sessions while retaining the existing Wayland plugin restrictions.
New Features:
Bug Fixes: