-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't hardcode plugin dir #679
base: master
Are you sure you want to change the base?
Conversation
Log: Use variable instead of hardcode for plugin dir
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hillwoodroc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @hillwoodroc. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -20,4 +20,4 @@ BUILD_VER = $(shell echo $(VERSION) | awk -F'[+_~-]' '{print $$2}' | sed 's/[^0- | |||
dh $@ | |||
|
|||
override_dh_auto_configure: | |||
dh_auto_configure -- -DDS_VERSION=${PACK_VER} -DENABLE_DEEPIN_NMQT=${ENABLE_DEEPIN_NMQT} | |||
dh_auto_configure -- -DCMAKE_INSTALL_LIBDIR=lib -DDS_VERSION=${PACK_VER} -DENABLE_DEEPIN_NMQT=${ENABLE_DEEPIN_NMQT} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样的改动,会把原有不是插件的so安装路径,也改掉吧。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果不改有什么问题没有?
/test all |
TAG Bot New tag: 0.0.36 |
TAG Bot New tag: 0.0.37 |
TAG Bot New tag: 0.0.38 |
TAG Bot New tag: 0.0.39 |
TAG Bot New tag: 0.0.40 |
TAG Bot New tag: 0.0.42 |
TAG Bot New tag: 0.0.43 |
Log: Use variable instead of hardcode for plugin dir
Should work with linuxdeepin/dde-tray-loader#110